Commit Graph

47223 Commits

Author SHA1 Message Date
Ruben Vallejo f5be2ec692 Add rfc token exchange logic to #handler success
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo eb1dac4d84 Change handler to return scope returned by the tokenset
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 448ff7b10b add offline_access scope to default scope list in #start
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 44483b9a0a refactor and add #refresh to pinnipedAuth provider
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 9fedd45be6 introduce audience parameter into start method and pass it into oauth state, fix integration tests
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 07dcd84379 Add redirect and error methods to the handlers strategy along with unit tests
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo ae059825ce Provider requests scopes
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 7dc7a38f3f authorization code exchange for a valid access_token
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Jamie Klassen b6f103de19 working integration test
Some thoughts at this point:
* it would be nice to gather all the fakePinnipedSupervisor setup together
  in the beforeEach rather than spreading it throughout the test body
* we need a real JWK/JWKS endpoint for token signing

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
Co-authored-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Jamie Klassen c1c062ad69 refine requirements for start method
Now the unit tests for the start method should render the '#start' describe
in index.test.ts redundant.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
Co-authored-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen 7c26171d2a refactor: minimal passing implementation
Removed all the code that wasn't impacting a failing test, and removed the
"ID token" test -- we'll start with access tokens since they are more important
for our token-exchange use case.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
Co-authored-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Ruben Vallejo 295dae8ab5 passing pinniped authprovider #handler responds with Id token test
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Ruben Vallejo 07df9ce153 implement consent redirect in new PinnipedAuthProvider
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen 7b4b8a0034 wip: auth-backed performs rfc 8693 token exchange
Just driving with the test at this point, hitting some trouble with
express-session/cookies but I have an idea for an approach when I return to it:

Hopefully it will be enough to enable all the right middlewares in our
express app under test and then use `request.agent` from supertest as in

https://github.com/ladjs/supertest/blob/25920e7a1d246b590123417bfce33221db88e947/README.md?plain=1#L244-L256

which can make an initial request to the `/start` endpoint and persist cookies
to the next request (the interesting one under test) to `/handler/frame`.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen 50223e7744 WIP: conditionally skip user profile
OIDC auth provider returns an empty user profile when the associated issuer has
no userinfo_endpoint. In theory this would enable access-delegation-only use
cases, but I haven't thought through all the consequences.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen d4cdf46e49 extract pinniped auth provider
a modified copy of the oidc auth provider, with a slight change in config
schema. A single high-level integration test checks this.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:54 -04:00
Patrik Oldsberg b535298539 Update .changeset/shiny-birds-melt.md
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-12 16:10:13 +02:00
Fredrik Adelöw 4468f80666 Merge pull request #20568 from backstage/freben/ghpage
Request slightly smaller pages from GitHub
2023-10-12 16:00:10 +02:00
Philipp Hugenroth f29a5d7ce8 Merge pull request #20019 from backstage/philipph/techdocs-di
Migrate TechDocs to new Frontend System
2023-10-12 15:55:02 +02:00
Jasper Boeijenga f092e285c0 Udpated changeset
Signed-off-by: Jasper Boeijenga <jboeijenga@gmail.com>
2023-10-12 15:25:37 +02:00
Jasper Boeijenga 8592169540 Remove local plugin
Signed-off-by: Jasper Boeijenga <jboeijenga@gmail.com>
2023-10-12 15:13:33 +02:00
Stan Lewis f1b349cfba fix: Tidy up i18nextTranslationApi change handling
This change removes some extra logic in i18NextTranslationApi's change
handling to ensure it always updates subscribers when a language change
is handled.  The relevant test was updated so it doesn't expect
snapshots that aren't loaded.  Fixes #20381

Signed-off-by: Stan Lewis <gashcrumb@gmail.com>
2023-10-12 09:10:46 -04:00
Djam 002c9562a6 Merge pull request #20394 from fedy97/hotfix/max-length-search-query
fix: max term length prevents backend to crash
2023-10-12 15:07:52 +02:00
Jasper Boeijenga 5a4437cf0c Added changeset
Signed-off-by: Jasper Boeijenga <jboeijenga@gmail.com>
2023-10-12 15:04:57 +02:00
Jasper Boeijenga ec59f3e388 Updated GA plugin playgrounds
Signed-off-by: Jasper Boeijenga <jboeijenga@gmail.com>
2023-10-12 15:01:28 +02:00
Fredrik Adelöw 4f16e60e6d Request slightly smaller pages from GitHub
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-10-12 15:00:06 +02:00
Fredrik Adelöw 8829a84b05 Merge pull request #20547 from Pike/dev-utils-devdeps
Make dev dependencies just devDependencies in dev-utils
2023-10-12 14:32:17 +02:00
Abhinv Singh Parmar c71ea9b2c1 Merge branch 'backstage:master' into master 2023-10-12 16:55:11 +05:30
parmar-abhinav 2be3922eb8 Add examples for github:deployKey:create scaffolder action
Signed-off-by: parmar-abhinav <abhi171b010@gmail.com>
2023-10-12 16:45:02 +05:30
backstage-goalie[bot] 3bfb2bf5da Merge pull request #20563 from backstage/renovate/sass-1.x-lockfile
fix(deps): update dependency sass to v1.69.3
2023-10-12 10:40:30 +00:00
Philipp Hugenroth cb0da26467 Update .changeset/modern-owls-mate.md
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Philipp Hugenroth <tudi2d@users.noreply.github.com>
2023-10-12 12:09:43 +02:00
Fredrik Adelöw 41381ddf1b Update .changeset/red-baboons-warn.md
Co-authored-by: Philipp Hugenroth <tudi2d@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-10-12 12:04:39 +02:00
renovate[bot] d8841fcef1 fix(deps): update dependency sass to v1.69.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-12 09:17:10 +00:00
backstage-goalie[bot] 546754dc6a Merge pull request #20560 from backstage/renovate/jose-4.x-lockfile
fix(deps): update dependency jose to v4.15.3
2023-10-12 09:14:04 +00:00
Patrik Oldsberg ae8812c151 changesets: tweak changeset for backend start change
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-12 11:13:46 +02:00
renovate[bot] 9cef849137 fix(deps): update dependency jose to v4.15.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-12 08:35:31 +00:00
backstage-goalie[bot] 67fd08dc86 Merge pull request #20557 from backstage/renovate/testing-library-jest-dom-6.x-lockfile
chore(deps): update dependency @testing-library/jest-dom to v6.1.4
2023-10-12 08:28:10 +00:00
Fredrik Adelöw dd0350379b stop using useHotMemoize
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-10-12 10:03:58 +02:00
Fredrik Adelöw 9e96f70d4a Merge pull request #20556 from backstage/freben/hostdiscovery
stop using SingleHostDiscovery
2023-10-12 10:03:12 +02:00
Camila Belo 2ac2f4a2fd Merge pull request #20487 from backstage/camilaibs/create-activelly-maintaned-plugins-script
Create build plugins report script
2023-10-12 09:47:44 +02:00
renovate[bot] 1ad75a7df1 chore(deps): update dependency @testing-library/jest-dom to v6.1.4
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-12 07:47:30 +00:00
Fredrik Adelöw 581578ddab Merge pull request #20496 from backstage/renovate/xterm-monorepo
fix(deps): update xterm monorepo
2023-10-12 09:39:39 +02:00
Patrik Oldsberg 87509c8d8e Merge pull request #20519 from gabrielhuber/master
core-app-api: Fixed bug in AppRouter to determine the correct signOutTargetUrl if app.baseUrl contains a basePath
2023-10-12 09:34:49 +02:00
Fredrik Adelöw ba9c46bdd7 stop using SingleHostDiscovery
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-10-12 09:22:23 +02:00
Camila Belo 85a51734ec refactor: optimize plugins report script
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-12 09:15:14 +02:00
Camila Belo d749e50595 fix: core maintainers commit check
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-12 08:53:10 +02:00
Patrik Oldsberg 409e24c2ea scripts/build-plugins-report: exclude changes to tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-12 08:53:10 +02:00
Patrik Oldsberg ef26bd727a scripts/build-plugins-report: don't open report at the end
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-12 08:53:10 +02:00
Camila Belo 565dff3dac refactor: apply review suggestions
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-12 08:53:10 +02:00
Camila Belo 882c5d5a5f chore: create build plugins report script
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-10-12 08:53:10 +02:00