Commit Graph

1766 Commits

Author SHA1 Message Date
Patrik Oldsberg 4f32c5a5d3 Merge pull request #702 from spotify/rugvip/pdiff
package/cli: added plugin:diff command
2020-05-05 11:06:16 +02:00
Ben Lambert 6d92a57bbc Merge pull request #717 from spotify/blam/scaffolder
plugin(scaffolder): Bring up to date with the latest backend template
2020-05-05 10:47:01 +02:00
Himanshu Mishra a93f194cb6 Break from loop if the test is successful
Making this mistake since while loops were created :(
2020-05-05 17:28:43 +09:00
blam 26094f82e3 chore: prettier is now automagically enabled, and fixing some pr review comments 2020-05-05 10:22:27 +02:00
Himanshu Mishra d050b1c791 Fix storybook webpack warning because of TS types 2020-05-05 17:10:14 +09:00
Himanshu Mishra fe2f7265d3 Add retries to find the text on page for e2e tests
The page may not be fully loaded on the first go. Hence, we wait for some time and then retry.
2020-05-05 16:57:55 +09:00
Himanshu Mishra f3f1cdb063 Temp commit to trigger Storybook build warning 2020-05-05 16:57:15 +09:00
Himanshu Mishra 706821337e Allow local storybook build even if there are warnings 2020-05-05 16:50:27 +09:00
Himanshu Mishra 23f083a19b Fail Storybook build if there are webpack compilation warnings
Create a Webpack plugin which looks for warnings at the end of the build.
Reference doc: https://webpack.js.org/contribute/writing-a-plugin/
2020-05-05 16:43:56 +09:00
Fredrik Adelöw 1063279b4a Merge pull request #713 from OrkoHunter/OrkoHunter/fix-storybook-build-warning
Fix Storybook compilation warning
2020-05-04 20:58:30 +02:00
blam e3ab861038 chore: fixing eslint config so we can use some great optional?.chaining?.stuff 2020-05-04 20:54:59 +02:00
Stefan Ålund 4bfadc1b7e Add disclaimer to Create view (#715) 2020-05-04 20:52:41 +02:00
blam 1af6cbea8d feat(scaffolder): Bring up to date with the latest changes in the inventory service 2020-05-04 20:39:13 +02:00
blam ef210545c9 Merge branch 'master' of github.com:spotify/backstage into blam/scaffolder
* 'master' of github.com:spotify/backstage:
  Rename Scaffolder -> Create (#712)
  Set the initial Storybook theme to light (#711)
  It's InputError then
  Even denser errors
  Better errors
  Show stack in dev
  [backend] use common error types
  Update Discord link in design docs, fix #672 (#710)
  [inventory] move out inventory instantiation + renaming
  Table component with filter and search (#600)
  [Storybook] Improve Status stories (#699)
  Fix blinking animation bug for Status Running component (#706)
  packages/cli: add lib ES2019 to common tsconfig
2020-05-04 19:40:18 +02:00
Himanshu Mishra 5363006759 Fix Storybook compilation warning
Typescript import and export has to be explicit.
Related issue #700
Related PR #701
2020-05-05 02:37:03 +09:00
Stefan Ålund 168db0fe9c Rename Scaffolder -> Create (#712)
* Rename Scaffolder -> Create

* Use Typography
2020-05-04 19:37:03 +02:00
Himanshu Mishra 8354d4a104 Set the initial Storybook theme to light (#711)
This fixes the inconsistency if user's OS/Browser theme is set to Dark mode.
2020-05-04 19:32:47 +02:00
Fredrik Adelöw 1d1589680d Merge pull request #709 from spotify/freben/errors
[backend] use common error types
2020-05-04 16:49:35 +02:00
Fredrik Adelöw 9724084186 It's InputError then 2020-05-04 16:42:40 +02:00
Fredrik Adelöw 129991fcfd Even denser errors 2020-05-04 16:34:17 +02:00
Fredrik Adelöw e5529c249b Better errors 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 1b4b98cd05 Show stack in dev 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 48b4a86a97 [backend] use common error types 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 70e2a62155 Merge pull request #707 from spotify/freben/iteraaaaate
[inventory] move out inventory instantiation + renaming
2020-05-04 16:05:32 +02:00
Niklas Ek 8c65917914 Update Discord link in design docs, fix #672 (#710) 2020-05-04 12:15:22 +02:00
Fredrik Adelöw 7c6b7b9b94 [inventory] move out inventory instantiation + renaming 2020-05-04 11:22:37 +02:00
Sebastian Qvarfordt 190f11c8f7 Table component with filter and search (#600)
* Initial table component with storybook example

* Moved dependencies to package/core

* Removed dependency to @backstage/core from base package.json

* Clean up some examples and remove type from columns, replacing with property align instead

* Removed more unused stuff and added toggle for filter input

* Fixed some lint issues

* Added example with material-table

* Convert column array passed into MaterialTable Backstage component into MT column array. Allow multiple values in one cell

* Removed subheader from MT

* Nicer double value cell

* Added custom sorting to example

* Cleaned up stories a bit

* Setting field instead of customSort

* Improve styling. Still needs better theme integration

* Using more colors from theme

* Fixed typing issue

* Removed react-table implementation and cleaned up material-table implementation

* Fixed some type issues

* Fixed lint issues
2020-05-04 11:10:35 +02:00
Stefan Ålund 031a4356f1 [Storybook] Improve Status stories (#699)
* [Storybook] Imrove Status stories

* Remove duplicate classes
2020-05-04 11:09:30 +02:00
Himanshu Mishra 3b2aeae05a Fix blinking animation bug for Status Running component (#706)
* Refer to keyframe as a material-ul variable

https://material-ui.com/guides/migration-v3/\#styles

* Update background color of Status

The background color should match with the theme's background color.
2020-05-04 06:34:08 +02:00
Patrik Oldsberg c4e0e7ed26 Merge pull request #703 from spotify/rugvip/es2019
packages/cli: add lib ES2019 to common tsconfig
2020-05-03 15:58:34 +02:00
blam cc8dbdfe5e Merge branch 'master' of github.com:spotify/backstage into blam/scaffolder
* 'master' of github.com:spotify/backstage:
  [Plugin] Explore features in Backstage (#696)
  [Storybook] Fix Storybook compilation warnings (#701)
  Make the inventory backend standalone runnable
2020-05-03 15:46:23 +02:00
blam 31c4785cc0 chore(scaffolder): Updating dependency graph to include docker api 2020-05-03 15:42:53 +02:00
Patrik Oldsberg 47d5d8da4f packages/cli: add lib ES2019 to common tsconfig 2020-05-03 15:36:05 +02:00
Patrik Oldsberg 41d879931d packages/cli: clearer plugin:diff output for package.json + fix 2020-05-03 15:28:06 +02:00
Stefan Ålund 7472e9a5c2 [Plugin] Explore features in Backstage (#696)
* Explore plugin

* Fixed styles and props

* Real conent

* Add Lighthouse and fix tests

* Add menu item

* Cleanup

* Change wording

* Update package.json

* Remove dead code

* Update yarn.lock

* Revert change to CODEOWNERS

* Reset yarn.lock to master

* Fix comments
2020-05-03 14:30:51 +02:00
Patrik Oldsberg 8e920cada8 packages/cli: add newline at the end of package.json during diff 2020-05-03 14:26:29 +02:00
Patrik Oldsberg 56ff5d7d97 packages/cli: add --check and --yes flags to plugin:diff 2020-05-03 14:25:36 +02:00
Patrik Oldsberg 7d02e1d15c packages/cli: split diff command implementation into multiple files 2020-05-03 14:21:20 +02:00
Patrik Oldsberg 5e5bb5a523 packages/cli: make it possible to override prompt func in diff 2020-05-03 14:02:31 +02:00
Patrik Oldsberg acb6212b49 packages/cli: add add handler for diff command to ensure files exist 2020-05-03 13:53:19 +02:00
Patrik Oldsberg 8ebb45e990 packages/cli: functional diff command with prompt for updates 2020-05-03 13:44:24 +02:00
Patrik Oldsberg 323f6b715a packages/cli: separate handlers for different template files in diff 2020-05-03 12:04:17 +02:00
Conal Cosgrove 8a16cf7067 [Storybook] Fix Storybook compilation warnings (#701)
* separate type import/exports

* update prettier to v2.0

* add explicit type import/exports
2020-05-02 21:39:22 +02:00
Bilawal Hameed d0e245ee3b fix: some incorrectly formatted markdown 2020-05-02 15:05:41 +02:00
Bilawal Hameed 8c1fd6e7d1 fix: update app to use new Radar API 2020-05-02 14:45:49 +02:00
Bilawal Hameed 27aa58470a fix: updated docs 2020-05-02 14:40:43 +02:00
Bilawal Hameed a4c05f203f fix: updated tests for RadarPage and RadarComponent 2020-05-02 14:40:31 +02:00
Bilawal Hameed d04855e98a fix: RadarPage uses RadarComponent under the hood 2020-05-02 14:40:12 +02:00
Bilawal Hameed 2c146cc86b fix: rename loadSampleData to getSampleData 2020-05-02 14:39:31 +02:00
Bilawal Hameed ef9e6ba6a8 feature: add RadarComponent and export as TechRadarComponent 2020-05-02 14:39:07 +02:00