Files
backstage/contrib
Ben Chidgey 7e2c0bc96f FIX: Stop sed escaping numbers 2 and 7 in Docker
An interesting edge case has come up whilst using BackStage.

When using the example frontend-with-nginx work to run a separate
frontend, whilst then providing an override for the
googleAnalyticsTrackingId in yaml config via
APP_CONFIG_app_googleAnalyticsTrackingId. I received an "Octal escape
sequences are not allowed in strict mode" error in the browser dev
console.

After looking into it it appears that the sed used escapes the numbers 2
and 7 if they are present in an APP_CONFIG_* ENV override value.
I happened to have both a 2 and a 7 in my GA ids, hence the edge case
part!

Of note this did not happen on my mac but it is present inside of the
nginx:mainline Docker container used in the example.

This fix simply removes the hex from the sed substitution regex and
replaces it with a single quote '

Signed-off-by: Ben Chidgey <ben@feedmypixel.com>
2021-09-23 17:34:54 +01:00
..

Backstage Contrib

This directory contains various community contributions related to Backstage.

Unless otherwise specified, all content in this hierarchy fall under the same licensing terms as in the rest of the repository, and come with no guarantees of functionality or fitness of purpose. That being said, we really appreciate contributions in here and encourage them being kept up to date.