Better option names
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
---
|
||||
'@backstage/frontend-defaults': minor
|
||||
'@backstage/frontend-defaults': patch
|
||||
---
|
||||
|
||||
Feature resolution logic used in `createApp` is now exposed via the `resolveFeatures` function.
|
||||
|
||||
@@ -48,6 +48,6 @@ export function createPublicSignInApp(options?: CreateAppOptions): {
|
||||
// @public (undocumented)
|
||||
export function resolveFeatures(options: {
|
||||
config: Config;
|
||||
providedFeatures?: (FrontendFeature | CreateAppFeatureLoader)[];
|
||||
features?: (FrontendFeature | CreateAppFeatureLoader)[];
|
||||
}): Promise<FrontendFeature[]>;
|
||||
```
|
||||
|
||||
@@ -91,7 +91,7 @@ export function createApp(options?: CreateAppOptions): {
|
||||
config,
|
||||
features: await resolveFeatures({
|
||||
config,
|
||||
providedFeatures: options?.features,
|
||||
features: options?.features,
|
||||
}),
|
||||
bindRoutes: options?.bindRoutes,
|
||||
extensionFactoryMiddleware: options?.extensionFactoryMiddleware,
|
||||
|
||||
@@ -101,11 +101,11 @@ function isBackstageFeature(obj: unknown): obj is FrontendFeature {
|
||||
/** @public */
|
||||
export async function resolveFeatures(options: {
|
||||
config: Config;
|
||||
providedFeatures?: (FrontendFeature | CreateAppFeatureLoader)[];
|
||||
features?: (FrontendFeature | CreateAppFeatureLoader)[];
|
||||
}): Promise<FrontendFeature[]> {
|
||||
const discoveredFeatures = getAvailableFeatures(options.config);
|
||||
const features = [appPlugin, ...discoveredFeatures];
|
||||
for (const entry of options.providedFeatures ?? []) {
|
||||
for (const entry of options.features ?? []) {
|
||||
if ('load' in entry) {
|
||||
try {
|
||||
const result = await entry.load({ config: options.config });
|
||||
|
||||
Reference in New Issue
Block a user