paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #14968 from backstage/rugvip/clean

Browse Source 
core-app-api: clean up some duplication in AppManager tests
This commit is contained in:
Patrik Oldsberg
2022-12-01 14:10:40 +01:00
committed by GitHub
parent 37df52d546 442e0d6d10
commit f382f2d324
1 changed files with 16 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core-app-api/src/app/AppManager.test.tsx
+16 -57
View File
@@ -21,7 +21,7 @@ import {
withLogCollector,
} from '@backstage/test-utils';
import { render, screen } from '@testing-library/react';
import React, { PropsWithChildren } from 'react';
import React, { PropsWithChildren, ReactNode } from 'react';
import { BrowserRouter, Navigate, Route, Routes } from 'react-router-dom';
import {
configApiRef,
@@ -164,19 +164,20 @@ describe('Integration Test', () => {
};
const icons = {} as AppIcons;
const themes = [
{
id: 'light',
title: 'Light Theme',
variant: 'light' as const,
Provider: ({ children }: { children: ReactNode }) => <>{children}</>,
},
];
it('runs happy paths', async () => {
const app = new AppManager({
apis: [noOpAnalyticsApi],
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [],
components,
@@ -224,14 +225,7 @@ describe('Integration Test', () => {
const app = new AppManager({
apis: [noOpAnalyticsApi],
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [],
components,
@@ -282,14 +276,7 @@ describe('Integration Test', () => {
const app = new AppManager({
apis,
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [
createPlugin({
@@ -345,14 +332,7 @@ describe('Integration Test', () => {
const app = new AppManager({
apis,
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [
createPlugin({
@@ -421,14 +401,7 @@ describe('Integration Test', () => {
const app = new AppManager({
apis,
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [],
components,
@@ -482,14 +455,7 @@ describe('Integration Test', () => {
const app = new AppManager({
apis: [],
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [],
components,
@@ -532,14 +498,7 @@ describe('Integration Test', () => {
const app = new AppManager({
apis: [],
defaultApis: [],
themes: [
{
id: 'light',
title: 'Light Theme',
variant: 'light',
Provider: ({ children }) => <>{children}</>,
},
],
themes,
icons,
plugins: [],
components,