Commit Graph

2583 Commits

Author SHA1 Message Date
Patrik Oldsberg 250db6cc2a docs: added plantuml generation script 2020-06-09 18:29:15 +02:00
Patrik Oldsberg c8294b3285 docs: added prettier config 2020-06-09 18:29:15 +02:00
Ben Lambert 00d33f93e4 Enable Filtering of the Catalog Page (#1143)
* feat(catalog/Filters): Add ability to render a React component as the count. Good for loading states and async data rendering for counts.

* chore(Catalog/filters): Updating the table so that we use loading states of the table rather than the panel

* chore(Catalog/filters): added some nice things for enabling the filtering with some nice count componeents

* feat(Catalog/filters): Fetch the correct data and added in enum types to make some nice resolvers

* chore(Catalog/filters): Use the new enum type here

* chore(Catalog/filters): Removing the unused import to fix lintig

* chore(Catalog/filters): Addressing some PR comments

* feat(catalog/filters): Making WebStorage return the same instance for the same bucket for subscriptions

* chore(core/Storage): fixing some issues with different instances of the storage and adding tests for it

* chore(catalog/filters): fixing some tests and trying to remove some of the act warnings in the tests
2020-06-09 13:28:40 +02:00
Fredrik Adelöw 4d7b28e89c Merge pull request #1199 from spotify/freben/unregister
Unbreak the unregister dialog after catalog changes
2020-06-09 10:33:15 +02:00
Fredrik Adelöw e2dc24d237 Remove final DOM nesting warning 2020-06-09 10:26:37 +02:00
Fredrik Adelöw 5f56f981b5 Unbreak the unregister dialog after catalog changes 2020-06-09 10:18:38 +02:00
Marcus Eide e9a2444c9a Documentation: Add guide for how to add an auth provider to the backend (#1145)
* Add guide for how to add a auth provider to the backend

* Move to new docs folder and small corrections

* Split oauth and non-oauth use-cases up and add more info about the verifyFunc

* Move summary to top and add note about non-oauth providers being experimental
2020-06-09 09:39:27 +02:00
Stefan Ålund 920f496a7f Use service theme (#1197)
* Use service theme

* Theme spacing

* breadcrumbs
2020-06-08 20:45:26 +02:00
Benjamin Rowell 056c794451 Make DismissibleBanner persistently dismissed #1153 (#1168)
* Enables DismissableBanner instance in localstorage

When dismissed, a string representation of the DismissableBanner
is sent to localstorage using the storageapi, to allow persistance in
a user session.

* Adds tests and cleans up DismissableBanner changes

DismissbleBanner now has an id prop. This prop is used when
adding a dismissed banner instance to web storage.

The namespace dismissed banners are added to is now set to
"notifications".

Removed refrences to old settings.

Added a test to check web storage functionality.

Updates CatalogPage to add id prop.

Updates CatalogPage test to ensure storageApiRef is valid.

* Updates DismissableBanner stories to include id.

* Adds ApiProvider to DismissableBanner stories.

* Trigger CI

* Removed jest calls and replaced with ErrorApi.

* Updates imports to @backstage/core
2020-06-08 20:16:51 +02:00
Patrik Oldsberg 2bbdf644c8 Merge pull request #1203 from spotify/rugvip/apimocks
packages/test-utils: added MockErrorApi and include in all test apps
2020-06-08 18:57:08 +02:00
Patrik Oldsberg 47d3f04bb7 Merge pull request #1201 from spotify/rugvip/nestapis
packages/core-api,test-utils
2020-06-08 18:21:01 +02:00
Patrik Oldsberg b5b95138f4 packages/test-utils: initial test registry with ErrorApi mock + tests 2020-06-08 18:00:19 +02:00
Patrik Oldsberg c01fe79642 packages/test-utils: added MockErrorApi 2020-06-08 18:00:19 +02:00
Patrik Oldsberg 676c4af4fd package/test-utils: provide renderInTestApp + act wrapping + docs + tests 2020-06-08 17:57:49 +02:00
Fredrik Adelöw f4ed330002 Deal with breaks in table titles (#1198) 2020-06-08 16:37:12 +02:00
Patrik Oldsberg f55959b680 packages/core-api: added .with() as another way to construct ApiRegistries 2020-06-08 16:09:07 +02:00
Patrik Oldsberg 076409a7b3 Merge pull request #1146 from spotify/rugvip/main
packages/cli: use publishConfig for publish config
2020-06-08 15:50:52 +02:00
Nikki Beesetti 3937a32993 Update FAQ.md (#951)
* Update FAQ.md

Finalized FAQ

* Update docs/FAQ.md

Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>

* Update Backstage security qn

* Fix review comments

Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Raghunandan Balachandran <soapraj@gmail.com>
2020-06-08 15:26:18 +02:00
Patrik Oldsberg 60bb2a5f9c Merge pull request #1172 from spotify/rugvip/runconf
docker,packages/config-loader: add support for runtime config injection from env
2020-06-08 15:25:07 +02:00
Patrik Oldsberg 04b6ed8789 Merge pull request #1154 from spotify/rugvip/lazy
packages/cli: add full support for dynamic imports in build, and build cli with build
2020-06-08 15:24:17 +02:00
Patrik Oldsberg f44c609244 Merge pull request #1139 from spotify/rugvip/bundleconfig
packages/cli: fix handling of public dir and hook it up to config
2020-06-08 15:24:06 +02:00
Fredrik Adelöw 74ad89f8e3 Merge pull request #1158 from spotify/freben/location-processors-3
RFC: Improve the way that locations are read
2020-06-08 15:07:29 +02:00
Patrik Oldsberg f0ba4fb892 Merge pull request #1127 from spotify/rugvip/config
packages/cli,core-api: move config reading and loading into separate packages
2020-06-08 14:21:36 +02:00
Patrik Oldsberg 6567f241b5 packages/core-api: make ApiProvider forward APIs from parent context 2020-06-08 12:06:24 +02:00
Stefan Ålund 23c57bd1a3 Minor tweaks to catalog UI (#1176)
* Minor tweaks to catalog UI

* Review feedback

* Use styles instead
2020-06-08 11:58:44 +02:00
Patrik Oldsberg 36773f612d Merge pull request #1190 from spotify/rugvip/radarfix
plugins/tech-radar: fix lint issue in RadarBubble
2020-06-08 11:19:21 +02:00
Patrik Oldsberg 9a1b363812 plugins/tech-radar: fix lint issue in RadarBubble 2020-06-08 11:12:15 +02:00
Stefan Ålund bea471e74c Fix backend startup instructions (#1188)
* Fix backend startup instructions

* Update README.md
2020-06-08 10:28:09 +02:00
Sebastian Qvarfordt 5b6b85a222 Merge pull request #1157 from hooloovooo/catalog-edit-link
Slightly more robust edit link creation
2020-06-08 10:11:22 +02:00
Patrik Oldsberg 24a11590cd Merge pull request #1186 from spotify/stefanalund-patch-1
Changed order of backend install instructions
2020-06-08 10:01:13 +02:00
Stefan Ålund 5726b40ee3 Changed order of backend install instructions 2020-06-08 09:53:14 +02:00
Sebastian Qvarfordt a6d44d18a4 Merge branch 'master' of github.com:spotify/backstage into catalog-edit-link 2020-06-08 09:51:31 +02:00
Nathan Calvank 42130988fe Issue 661 Tech Radar Typescript refactor (#1080)
* Refactor RadarFooter

* Refactor RadarLegend Pt 1

* Refactor RadarLegend Pt 2

Seeing some errors that I don't fully understand around the proptypes
assertions seemingly being treated as null | undefined values.

It looks like I'll need to type Segment, which is not explicitly
in-scope for this issue.

* Fix segments regression

I incorrectly added type safety to the original implementation, causing
the segments to no longer be populated here. This change fixes that
regression while retaining the type safety.

This is all necessary because qidx and ridx are apparently both
nullable.

* Resolve remaining RadarLegend warnings

* Refactor RadarEntry

* Forcibly skip hooks to revert migration prettify

* Refactor RadarGrid

* Refactor RadarPlot & Best effort with PropTypes

A global search looks like no other plugins use PropTypes. I'm about to
remove them in the next commit because shapes don't seem to cooperate
with TypeScript, making the PropTypes either so vague that they're
mostly useless or specific enough to fail the build.

With that said, I wanted to get this version committed in case I need to
roll back to here. I wouldn't want to redo this work.

* Remove PropTypes from refactored components

The build now passes.

* Refactor RadarBubble

* Refactor Radar

* Move Radar functions out of component file

I could see these being split into separate files, but I think this is
enough for now.

* Small function signature change

* Align types

I'm not confident in this change. I'm very unclear about the reasoning
behind the type definitions in api.ts as they don't reflect the shape of
the values that I see when I print `data.entries` in the console.

The value of data.entries reflects a fully-populated Entry[], not a
RadarEntry[].

As such, I'm also not sure about the sample data. I would be more
hesitant to updated it, but the fact that the rest of the components
seem to be expecting that data makes it seem fairly clear that it must
be required to be in the updated shape.
2020-06-08 09:13:03 +02:00
dependabot-preview[bot] fb8e834b15 build(deps-dev): bump eslint-plugin-cypress from 2.10.3 to 2.11.1 (#1184)
Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.10.3 to 2.11.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases)
- [Commits](https://github.com/cypress-io/eslint-plugin-cypress/compare/v2.10.3...v2.11.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 09:11:06 +02:00
dependabot-preview[bot] bf5b537697 build(deps): bump eslint-plugin-import from 2.20.2 to 2.21.1 (#1183)
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.2 to 2.21.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.20.2...v2.21.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 09:10:32 +02:00
Stefan Ålund 6682c9fb76 Fix backend not starting (#1185)
Fixes https://github.com/spotify/backstage/issues/1177
2020-06-08 09:10:00 +02:00
Burhanuddin Udaipurwala 66db572355 fix page reload when clicking on logo (#1178) 2020-06-08 09:00:45 +02:00
Fredrik Adelöw 9f02cf4a30 LocationProcessorSink -> LocationProcessorEmit 2020-06-08 07:14:16 +02:00
Stefan Ålund cd5590a21b Add background color for tabs (#1170)
* Add background color for tabs

* Use BackstageTheme

* Use paper instead

* Use standard theme
2020-06-07 20:30:50 +02:00
Ben Lambert c7ab517652 chore(navigation/tabs): fixing prop type validation (#1173) 2020-06-07 16:15:09 +02:00
Patrik Oldsberg fe2d04ae3b docker: add runtime config injection from env 2020-06-07 14:43:20 +02:00
Fredrik Adelöw e19a93ee55 Get rid of the generators 2020-06-06 23:50:09 +02:00
Fredrik Adelöw 61a02be0f4 Add logging and fix last bug 2020-06-06 22:11:42 +02:00
Fredrik Adelöw d68e4f2bd0 Switch to using generators 2020-06-06 22:11:42 +02:00
Fredrik Adelöw fe16d8ee8d chore(catalog-backend): make LocationReader, that runs a chain of processors 2020-06-06 22:09:32 +02:00
Patrik Oldsberg 650779412c packages/config-loader: add build- and dev-time config through env + tests 2020-06-06 17:06:47 +02:00
Patrik Oldsberg c40a2a5e61 packages/core-api: move router component inside app and configure it with base path 2020-06-06 17:06:18 +02:00
Stefan Ålund ec4aa3d59f Change example component names (#1165) 2020-06-06 17:03:52 +02:00
Ben Lambert 8e528f0bcb Merge pull request #1161 from spotify/sebastianq/component-navigation
Added Sub Tabs on Component Page and Catalog Page
2020-06-06 16:50:56 +02:00
Patrik Oldsberg 2edcd94793 packages/cli: open browser at correct path when serving bundle 2020-06-06 15:54:48 +02:00