Rogerio Angeliski
59f07a8eaf
Merge branch 'backstage:master' into add-tasks-owner
2022-05-31 13:36:17 -03:00
blam
14f38803d0
chore: reset one file
...
Signed-off-by: blam <ben@blam.sh >
2022-05-31 16:54:39 +02:00
blam
c67af10222
chore: fixing api-report
...
Signed-off-by: blam <ben@blam.sh >
2022-05-31 16:43:57 +02:00
blam
698c55f182
chore: code review changes
...
Signed-off-by: blam <ben@blam.sh >
2022-05-31 16:42:51 +02:00
Ben Lambert
e15c24ddb5
Merge pull request #11689 from backstage/changeset-release/master
...
Version Packages (next)
2022-05-31 15:57:04 +02:00
blam
69b737c568
Merge remote-tracking branch 'origin' into add-tasks-owner
...
* origin: (56 commits)
scaffolder-backend: fix merge conflict in router
scaffolder: disable global save button in template editor if no files are dirty
scaffolder: update API report
scaffolder: remove unnecessary TemplateFileSystemAccess interface
scaffolder: wrap dry-run log body in an outer object
scaffolder: fix life
scaffolder: make dry-run secrets optional to match task execution
scaffolder: rename dry-run contents -> directoryContents
scaffolder-backend: refactor actions to use serializeDirectoryContents
scaffolder-backend: clarifying comment about done
scaffolder-backend: add dry-run request body validation
scaffolder-backend: validate dry-run template input
sfaffolder: switch /v2/dryrun to /v2/dry-run
scaffolder,scaffolder-backend: fix API reports
scaffolder: fix dryRun implementation in ScaffolderClient
scaffolder: add test for TemplateEditorBrowser
scaffolder: add test for TemplateEditorPage
scaffolder: add test for DryRunResultsView
scaffolder: memo methods in DryRunProvider
scaffolder: add DryRunResultsList tests
...
Signed-off-by: blam <ben@blam.sh >
2022-05-31 14:58:51 +02:00
github-actions[bot]
a13ab262de
Version Packages (next)
2022-05-31 11:51:41 +00:00
Patrik Oldsberg
2c54d6446f
Merge pull request #11173 from backstage/rugvip/dry-run
...
scaffolder: add dry-run + Template Editor
2022-05-31 13:46:00 +02:00
Patrik Oldsberg
b2e0687363
scaffolder-backend: fix merge conflict in router
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:27:19 +02:00
Patrik Oldsberg
139f8f08a2
scaffolder: disable global save button in template editor if no files are dirty
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:25 +02:00
Patrik Oldsberg
407996a8bd
scaffolder: update API report
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:25 +02:00
Patrik Oldsberg
a2490f64fe
scaffolder: remove unnecessary TemplateFileSystemAccess interface
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:25 +02:00
Patrik Oldsberg
73e427c405
scaffolder: wrap dry-run log body in an outer object
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:25 +02:00
Patrik Oldsberg
c94fb6d666
scaffolder: fix life
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:25 +02:00
Patrik Oldsberg
b817af39ad
scaffolder: make dry-run secrets optional to match task execution
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:25 +02:00
Patrik Oldsberg
c7a5d8d7ae
scaffolder: rename dry-run contents -> directoryContents
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
03a467ebc9
scaffolder-backend: refactor actions to use serializeDirectoryContents
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
63f2164c1d
scaffolder-backend: clarifying comment about done
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
0203775f4b
scaffolder-backend: add dry-run request body validation
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
caafe75e89
scaffolder-backend: validate dry-run template input
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
36c39f9b42
sfaffolder: switch /v2/dryrun to /v2/dry-run
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
b622410ef0
scaffolder,scaffolder-backend: fix API reports
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
636dc85781
scaffolder: fix dryRun implementation in ScaffolderClient
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
d59ec5c6d5
scaffolder: add test for TemplateEditorBrowser
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
01db4019e0
scaffolder: add test for TemplateEditorPage
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
71228274ae
scaffolder: add test for DryRunResultsView
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
e48ca034e9
scaffolder: memo methods in DryRunProvider
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
4b839c4f02
scaffolder: add DryRunResultsList tests
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
88b81c3e6f
scaffolder: add tests for DryRunResults
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
05b6044399
scaffolder: memo DryRunContext value
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
ace95e391c
scaffolder: flatten TemplateEditorPage structure
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:24 +02:00
Patrik Oldsberg
289d349199
scaffolder: always show file reload in TemplateEditorTextArea
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
f7805dfea8
scaffolder: add wrapper to TemplateEditorForm to handle overflow
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
c98cfa0e6c
scaffolder: refactor TemplateFormPreviewer to use common components
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
3c87f60481
scaffolder: tweak names of TemplateEditor components
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
6758e83662
scaffolder: extract TemplateEditorBrowser
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
5146bc96fc
scaffolder: extract TemplateEditorForm
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
a788dacc73
scaffolder: extract TemplateEditorTextArea
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
48307fbf0d
scaffolder: remove unused DirectoryLoader
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
5d63d15dbf
scaffolder: extract FileBrowser
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
5edc82d02a
scaffolder: extract DryRunResultsView + refactor DryRunResults
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
483aa3a47b
scaffolder: extract DryRunResultsList
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
bb95aca5aa
scaffolder: extract DryRunResultsSplitView
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
7e41a70dee
scaffolder: move TemplateEditorDryRunResults to subdir
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:23 +02:00
Patrik Oldsberg
633afdd01b
scaffolder: fix codemirror import
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:22 +02:00
Patrik Oldsberg
93af1ae48e
scaffolder: move TemplateEditor components into subdirectory
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:22 +02:00
Patrik Oldsberg
84e3c67ae3
scaffolder: fix width for dry run results view side pane
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:22 +02:00
Patrik Oldsberg
a9e587c761
scaffolder: fix template dry run results panel not expanding on first show
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:22 +02:00
Patrik Oldsberg
dc1d67fc5b
scaffolder: tweak TemplateEditor error panel
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:22 +02:00
Patrik Oldsberg
d989e0c203
scaffolder: remove mock editor data
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-05-31 13:24:22 +02:00