Commit Graph

2531 Commits

Author SHA1 Message Date
Patrik Oldsberg 6567f241b5 packages/core-api: make ApiProvider forward APIs from parent context 2020-06-08 12:06:24 +02:00
Patrik Oldsberg 36773f612d Merge pull request #1190 from spotify/rugvip/radarfix
plugins/tech-radar: fix lint issue in RadarBubble
2020-06-08 11:19:21 +02:00
Patrik Oldsberg 9a1b363812 plugins/tech-radar: fix lint issue in RadarBubble 2020-06-08 11:12:15 +02:00
Stefan Ålund bea471e74c Fix backend startup instructions (#1188)
* Fix backend startup instructions

* Update README.md
2020-06-08 10:28:09 +02:00
Sebastian Qvarfordt 5b6b85a222 Merge pull request #1157 from hooloovooo/catalog-edit-link
Slightly more robust edit link creation
2020-06-08 10:11:22 +02:00
Patrik Oldsberg 24a11590cd Merge pull request #1186 from spotify/stefanalund-patch-1
Changed order of backend install instructions
2020-06-08 10:01:13 +02:00
Stefan Ålund 5726b40ee3 Changed order of backend install instructions 2020-06-08 09:53:14 +02:00
Sebastian Qvarfordt a6d44d18a4 Merge branch 'master' of github.com:spotify/backstage into catalog-edit-link 2020-06-08 09:51:31 +02:00
Nathan Calvank 42130988fe Issue 661 Tech Radar Typescript refactor (#1080)
* Refactor RadarFooter

* Refactor RadarLegend Pt 1

* Refactor RadarLegend Pt 2

Seeing some errors that I don't fully understand around the proptypes
assertions seemingly being treated as null | undefined values.

It looks like I'll need to type Segment, which is not explicitly
in-scope for this issue.

* Fix segments regression

I incorrectly added type safety to the original implementation, causing
the segments to no longer be populated here. This change fixes that
regression while retaining the type safety.

This is all necessary because qidx and ridx are apparently both
nullable.

* Resolve remaining RadarLegend warnings

* Refactor RadarEntry

* Forcibly skip hooks to revert migration prettify

* Refactor RadarGrid

* Refactor RadarPlot & Best effort with PropTypes

A global search looks like no other plugins use PropTypes. I'm about to
remove them in the next commit because shapes don't seem to cooperate
with TypeScript, making the PropTypes either so vague that they're
mostly useless or specific enough to fail the build.

With that said, I wanted to get this version committed in case I need to
roll back to here. I wouldn't want to redo this work.

* Remove PropTypes from refactored components

The build now passes.

* Refactor RadarBubble

* Refactor Radar

* Move Radar functions out of component file

I could see these being split into separate files, but I think this is
enough for now.

* Small function signature change

* Align types

I'm not confident in this change. I'm very unclear about the reasoning
behind the type definitions in api.ts as they don't reflect the shape of
the values that I see when I print `data.entries` in the console.

The value of data.entries reflects a fully-populated Entry[], not a
RadarEntry[].

As such, I'm also not sure about the sample data. I would be more
hesitant to updated it, but the fact that the rest of the components
seem to be expecting that data makes it seem fairly clear that it must
be required to be in the updated shape.
2020-06-08 09:13:03 +02:00
dependabot-preview[bot] fb8e834b15 build(deps-dev): bump eslint-plugin-cypress from 2.10.3 to 2.11.1 (#1184)
Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.10.3 to 2.11.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases)
- [Commits](https://github.com/cypress-io/eslint-plugin-cypress/compare/v2.10.3...v2.11.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 09:11:06 +02:00
dependabot-preview[bot] bf5b537697 build(deps): bump eslint-plugin-import from 2.20.2 to 2.21.1 (#1183)
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.2 to 2.21.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.20.2...v2.21.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 09:10:32 +02:00
Stefan Ålund 6682c9fb76 Fix backend not starting (#1185)
Fixes https://github.com/spotify/backstage/issues/1177
2020-06-08 09:10:00 +02:00
Burhanuddin Udaipurwala 66db572355 fix page reload when clicking on logo (#1178) 2020-06-08 09:00:45 +02:00
Stefan Ålund cd5590a21b Add background color for tabs (#1170)
* Add background color for tabs

* Use BackstageTheme

* Use paper instead

* Use standard theme
2020-06-07 20:30:50 +02:00
Ben Lambert c7ab517652 chore(navigation/tabs): fixing prop type validation (#1173) 2020-06-07 16:15:09 +02:00
Stefan Ålund ec4aa3d59f Change example component names (#1165) 2020-06-06 17:03:52 +02:00
Ben Lambert 8e528f0bcb Merge pull request #1161 from spotify/sebastianq/component-navigation
Added Sub Tabs on Component Page and Catalog Page
2020-06-06 16:50:56 +02:00
blam 40b07d521b chore(Catalog/Tabs): remove extraneous file from otber branch 2020-06-06 15:07:41 +02:00
blam b08c5919f4 Merge branch 'master' of github.com:spotify/backstage into sebastianq/component-navigation
* 'master' of github.com:spotify/backstage:
  packages/cli: avoid duplicate dependency warning in E2E test
  build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
  fix: import from package
  fix: type checking
  fix: tests
  Ran yarn install
  fix: show list of components in removal dialog
  fix: github actions
  fix: make locations fetching work
  feature: extract getLocationById method, wrap location fetching in useAsync
2020-06-06 14:54:24 +02:00
Patrik Oldsberg f5ed538789 Merge pull request #1164 from spotify/rugvip/nowarn
packages/cli: avoid duplicate dependency warning in E2E test
2020-06-06 12:53:51 +02:00
Patrik Oldsberg 18c1eb3835 packages/cli: avoid duplicate dependency warning in E2E test 2020-06-06 12:37:28 +02:00
Nikita Dudnik a0ff18b12e Merge pull request #1160 from spotify/ndudnik/unregister-component
Unregister component: front-end
2020-06-05 23:05:29 +02:00
Fredrik Adelöw 31bec057f1 Merge pull request #1162 from spotify/dependabot/npm_and_yarn/websocket-extensions-0.1.4
build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
2020-06-05 22:42:31 +02:00
dependabot-preview[bot] f7c9e3677a build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.**
- [Release notes](https://github.com/faye/websocket-extensions-node/releases)
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-05 20:25:18 +00:00
blam 72a7c73e9f feat(Catalog/tabs): added some sample tabs for now 2020-06-05 17:40:24 +02:00
Sebastian Qvarfordt 8742e85eb7 Added HeaderTabs to ComponentPage 2020-06-05 16:54:36 +02:00
Nikita Nek Dudnik 2744a98ac5 fix: import from package 2020-06-05 16:40:27 +02:00
Nikita Nek Dudnik a4f08e3fcc fix: type checking 2020-06-05 16:29:46 +02:00
Nikita Nek Dudnik 48a71d6300 fix: tests 2020-06-05 16:22:44 +02:00
Fredrik Adelöw a9ea32e57d Merge pull request #1159 from spotify/freben/yarnlock
Ran yarn install
2020-06-05 16:14:25 +02:00
Fredrik Adelöw 91853e1f6d Ran yarn install 2020-06-05 15:23:14 +02:00
Nikita Nek Dudnik e2c6864055 Merge remote-tracking branch 'origin' into ndudnik/unregister-component 2020-06-05 14:57:16 +02:00
Nikita Nek Dudnik ed3a404de0 fix: show list of components in removal dialog 2020-06-05 14:23:44 +02:00
Nikita Nek Dudnik 10980727a7 fix: github actions 2020-06-05 14:14:07 +02:00
blam 241dc49797 chore(Catalog/Navigation): Added some basic tabs to the subheader grid area 2020-06-05 14:05:01 +02:00
Sebastian Qvarfordt bcb50c9325 Different edit links depending on type. Only github for now though. 2020-06-05 12:53:16 +02:00
Sebastian Qvarfordt c655a133a3 Slightly more robust edit link creation 2020-06-05 12:09:07 +02:00
Nikita Nek Dudnik 29f7f1c333 fix: make locations fetching work 2020-06-05 11:55:08 +02:00
Patrik Oldsberg e396996792 Merge pull request #1140 from spotify/auth-frontend-state
Auth frontend state
2020-06-05 11:48:16 +02:00
Nikita Nek Dudnik e1477fa635 feature: extract getLocationById method, wrap location fetching in useAsync 2020-06-05 11:36:52 +02:00
Sebastian Qvarfordt de30e7f6ee Merge pull request #1155 from hooloovooo/catalog-edit-link
Catalog edit link
2020-06-05 11:29:45 +02:00
Sebastian Qvarfordt 78f5e50761 Merge branch 'master' of github.com:spotify/backstage into catalog-edit-link 2020-06-05 11:08:03 +02:00
Ivan Shmidt e5f856abb3 Merge pull request #1111 from spotify/mob/register-unregister-components
Register component flow
2020-06-05 11:07:25 +02:00
Sebastian Qvarfordt 2f474224b0 Replace blob with edit in link 2020-06-05 11:03:30 +02:00
Kat Zhou 457be7a76b new headline image for README (#1122)
* new headline image for README

* Resize

Co-authored-by: Stefan Ålund <alund@spotify.com>
2020-06-05 10:56:37 +02:00
Patrik Oldsberg 0347cc6508 Merge pull request #1144 from spotify/rugvip/build
packages/cli: add separate build command for non-plugin packages
2020-06-05 10:47:30 +02:00
Sebastian Qvarfordt 0cb79192e8 Merge branch 'catalog-edit-link' of github.com:hooloovooo/backstage into catalog-edit-link 2020-06-05 10:36:27 +02:00
dependabot-preview[bot] b717971ec1 build(deps-dev): bump @types/html-webpack-plugin from 3.2.2 to 3.2.3 (#1148)
Bumps [@types/html-webpack-plugin](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/html-webpack-plugin) from 3.2.2 to 3.2.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/html-webpack-plugin)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-05 08:39:28 +02:00
dependabot-preview[bot] c1aa4708b4 build(deps): bump @testing-library/jest-dom from 5.7.0 to 5.9.0 (#1151)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.7.0 to 5.9.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.7.0...v5.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-05 08:39:10 +02:00
dependabot-preview[bot] dc971e4577 build(deps-dev): bump lint-staged from 10.1.0 to 10.2.9 (#1149)
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.1.0 to 10.2.9.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v10.1.0...v10.2.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-05 08:38:30 +02:00