Commit Graph

1532 Commits

Author SHA1 Message Date
Himanshu Mishra 82b6f1e4cb Retry search text for any type of error 2020-05-05 20:09:03 +09:00
Himanshu Mishra 9ea93173f0 Do browser.visit again after getting error in finding text 2020-05-05 20:07:43 +09:00
Himanshu Mishra fe088038d6 Better variable names
attemptsToLoad -> loadAttempts
maxAttempts -> maxLoadAttempts
attemptsToSearchText -> findTextAttempts
maxAttemptsToSearchText -> maxFindTextAttempts
2020-05-05 20:06:16 +09:00
Himanshu Mishra a93f194cb6 Break from loop if the test is successful
Making this mistake since while loops were created :(
2020-05-05 17:28:43 +09:00
Himanshu Mishra fe2f7265d3 Add retries to find the text on page for e2e tests
The page may not be fully loaded on the first go. Hence, we wait for some time and then retry.
2020-05-05 16:57:55 +09:00
Fredrik Adelöw 1d1589680d Merge pull request #709 from spotify/freben/errors
[backend] use common error types
2020-05-04 16:49:35 +02:00
Fredrik Adelöw 9724084186 It's InputError then 2020-05-04 16:42:40 +02:00
Fredrik Adelöw 129991fcfd Even denser errors 2020-05-04 16:34:17 +02:00
Fredrik Adelöw e5529c249b Better errors 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 1b4b98cd05 Show stack in dev 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 48b4a86a97 [backend] use common error types 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 70e2a62155 Merge pull request #707 from spotify/freben/iteraaaaate
[inventory] move out inventory instantiation + renaming
2020-05-04 16:05:32 +02:00
Niklas Ek 8c65917914 Update Discord link in design docs, fix #672 (#710) 2020-05-04 12:15:22 +02:00
Fredrik Adelöw 7c6b7b9b94 [inventory] move out inventory instantiation + renaming 2020-05-04 11:22:37 +02:00
Sebastian Qvarfordt 190f11c8f7 Table component with filter and search (#600)
* Initial table component with storybook example

* Moved dependencies to package/core

* Removed dependency to @backstage/core from base package.json

* Clean up some examples and remove type from columns, replacing with property align instead

* Removed more unused stuff and added toggle for filter input

* Fixed some lint issues

* Added example with material-table

* Convert column array passed into MaterialTable Backstage component into MT column array. Allow multiple values in one cell

* Removed subheader from MT

* Nicer double value cell

* Added custom sorting to example

* Cleaned up stories a bit

* Setting field instead of customSort

* Improve styling. Still needs better theme integration

* Using more colors from theme

* Fixed typing issue

* Removed react-table implementation and cleaned up material-table implementation

* Fixed some type issues

* Fixed lint issues
2020-05-04 11:10:35 +02:00
Stefan Ålund 031a4356f1 [Storybook] Improve Status stories (#699)
* [Storybook] Imrove Status stories

* Remove duplicate classes
2020-05-04 11:09:30 +02:00
Himanshu Mishra 3b2aeae05a Fix blinking animation bug for Status Running component (#706)
* Refer to keyframe as a material-ul variable

https://material-ui.com/guides/migration-v3/\#styles

* Update background color of Status

The background color should match with the theme's background color.
2020-05-04 06:34:08 +02:00
Patrik Oldsberg c4e0e7ed26 Merge pull request #703 from spotify/rugvip/es2019
packages/cli: add lib ES2019 to common tsconfig
2020-05-03 15:58:34 +02:00
Patrik Oldsberg 47d5d8da4f packages/cli: add lib ES2019 to common tsconfig 2020-05-03 15:36:05 +02:00
Stefan Ålund 7472e9a5c2 [Plugin] Explore features in Backstage (#696)
* Explore plugin

* Fixed styles and props

* Real conent

* Add Lighthouse and fix tests

* Add menu item

* Cleanup

* Change wording

* Update package.json

* Remove dead code

* Update yarn.lock

* Revert change to CODEOWNERS

* Reset yarn.lock to master

* Fix comments
2020-05-03 14:30:51 +02:00
Conal Cosgrove 8a16cf7067 [Storybook] Fix Storybook compilation warnings (#701)
* separate type import/exports

* update prettier to v2.0

* add explicit type import/exports
2020-05-02 21:39:22 +02:00
Fredrik Adelöw 8e0ebb66d9 Merge pull request #686 from spotify/freben/inventory-again
Make the inventory backend standalone runnable
2020-05-01 22:30:59 +02:00
Fredrik Adelöw 92feb76252 Make the inventory backend standalone runnable
And also make a proposed split of how the loggers are handled.

Now logs look like

```
{
  "type": "incomingRequest",
  "service": "backstage",
  "timestamp": "2020-04-30T14:29:04.002Z",
  "message": "...",
  "level": "info"
}
```

for requests, and then if the plugin logs something properly

```
{
  "type": "plugin",
  "service": "backstage",
  "plugin": "inventory",
  "timestamp": "2020-04-30T14:29:04.002Z",
  "message": "...",
  "level": "info"
}
```
2020-05-01 21:59:20 +02:00
Ben Lambert cd156a44c1 Merge pull request #651 from spotify/blam/scaffolder
[Plugin] Start of the Scaffolder Plugin
2020-05-01 17:52:58 +02:00
blam b17462af8b chore(scaffolder): compiled is now .esm not .cjs 2020-05-01 17:35:34 +02:00
blam fb71dc957c Merge branch 'master' of github.com:spotify/backstage into blam/scaffolder
* 'master' of github.com:spotify/backstage:
  packages/cli: added jest transform for .esm.js files
  plugins/graphiql: use dynamic import to load graphiql
  packages/cli: target modern browsers and switch output to module
  packages/storybook: make local core imports resolve to core src
  packages/storybook: use ts-loader for JS too
2020-05-01 17:19:55 +02:00
Patrik Oldsberg 38257822c2 Merge pull request #655 from spotify/rugvip/modernize
packages/cli: target modern browsers and switch output to module + dynamic graphiql import
2020-05-01 16:54:16 +02:00
Patrik Oldsberg 2068829f4f packages/cli: added jest transform for .esm.js files 2020-05-01 15:55:48 +02:00
Patrik Oldsberg 85452a02b7 plugins/graphiql: use dynamic import to load graphiql 2020-05-01 15:55:48 +02:00
Patrik Oldsberg b87d266c74 packages/cli: target modern browsers and switch output to module 2020-05-01 15:55:47 +02:00
Patrik Oldsberg 4c7a9784cc Merge pull request #695 from spotify/rugvip/fmlsb
packages/storybook: use ts-loader for JS + resolve @backstage/core imports
2020-05-01 15:52:08 +02:00
Patrik Oldsberg 5448e54e94 packages/storybook: make local core imports resolve to core src 2020-05-01 15:28:08 +02:00
Patrik Oldsberg db9d9f7f08 packages/storybook: use ts-loader for JS too 2020-05-01 15:28:08 +02:00
blam 3be8104c5b chore: woops wrong name here 2020-05-01 04:13:46 +02:00
blam 7a578fafb1 chore: trying to fix the lockfile hoping this works? 2020-05-01 04:02:14 +02:00
blam c795d6fbbf Merge branch 'master' of github.com:spotify/backstage into blam/scaffolder
* 'master' of github.com:spotify/backstage:
  404 page (#681)
  packages/core: remove old widget related things
  Address comments
  Add TabbedCard and CardTab to the exported layouts components
  Add a backend-common package with common concerns such as logging
  Move backend lint config to cli config
  Translate SortableTable to Typescript
2020-05-01 03:44:30 +02:00
Emma Indal e953259871 404 page (#681)
* core: Implemented error page, closes #170

* Swap margin to padding

* more ui work

* Convert to TypeScript, functioncal components, use useStyles/makeStyles, clean up some styles and use components from material ui

* fixup

* Fix lint errors

* Remove unused theme consumer

* Decrease max size of image

* Remove BackstageTheme added by mistake on rebase

* Add space to text

* Use BackstageTheme type and change color from palette

* Add test

Co-authored-by: Ryan Pannell <ryan@osukl.com>
2020-04-30 21:12:51 +02:00
Fredrik Adelöw da7522b671 Merge pull request #676 from spotify/freben/backend-common
Add a backend-common package with common concerns such as logging
2020-04-30 14:35:58 +02:00
Patrik Oldsberg fe25dd9d4e Merge pull request #684 from spotify/rugvip/nema-widgets
packages/core: remove old widget related things
2020-04-30 14:13:15 +02:00
Patrik Oldsberg ae0d3994e9 packages/core: remove old widget related things 2020-04-30 12:23:30 +02:00
Fredrik Adelöw fd0d4150f0 Address comments 2020-04-30 10:53:49 +02:00
Patrik Oldsberg 3ae7021d9c Merge pull request #680 from K-Phoen/export-tabbed-card
Add TabbedCard and CardTab to the exported layouts components
2020-04-30 00:09:55 +02:00
Kévin Gomez 04db160996 Add TabbedCard and CardTab to the exported layouts components 2020-04-29 23:31:59 +02:00
Patrik Oldsberg ed8729a171 Merge pull request #654 from Koroeskohr/translate-sortabletable
Translate SortableTable to Typescript
2020-04-29 16:42:59 +02:00
Fredrik Adelöw 77d48d8794 Add a backend-common package with common concerns such as logging 2020-04-29 11:32:30 +02:00
Fredrik Adelöw a92f662d88 Merge pull request #670 from spotify/freben/backendlint
Move backend lint config to cli config
2020-04-29 11:24:27 +02:00
blam 89f29c65f9 Merge branch 'master' of github.com:spotify/backstage into blam/scaffolder
* 'master' of github.com:spotify/backstage:
  add adr log to repository (#665)
2020-04-29 11:04:48 +02:00
Fredrik Adelöw 69a3fa79e7 Move backend lint config to cli config 2020-04-29 11:01:40 +02:00
eywoon 9ccf3b0623 add adr log to repository (#665) 2020-04-29 10:25:44 +02:00
blam 247e58689b Merge branch 'blam/scaffolder' of github.com:spotify/backstage into blam/scaffolder
* 'blam/scaffolder' of github.com:spotify/backstage: (34 commits)
  yarn.lock: bump eslint-plugin-notice
  packages/dev-utils: use doc comments + text fix in README
  darkMode: fix HorizontalScrollGrid (#666) (#668)
  darkMode: fix bottom link (#664)
  Add padding for all Stories (#663)
  Use useInterval() hook to refetch audit status in lighthouse plugin WIP (#623)
  run yarn install against master yarn.lock
  changed object to Partial type
  adjust getBBox polyfill logic
  re-ran yarn.lock
  added initial docs
  added tests for RadarPage
  re-ran yarn install
  add polyfill for SVGElement.prototype.getBBox (not supported in JSDOM)
  migrated RadarBubble to material-ui styles
  migrated RadarEntry to material-ui styles
  migrated RadarFooter to material-ui styles
  migrated RadarLegend to material-ui styles
  migrated RadarGrid to material-ui styles
  removed css modules from css
  ...
2020-04-28 22:55:04 +02:00