Commit Graph

71009 Commits

Author SHA1 Message Date
Patrik Oldsberg 9810310781 Update changeset messages per review feedback
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 12:56:54 +01:00
Patrik Oldsberg aac8cd4cc2 repo-tools: Strip ANSI codes and set NO_COLOR for CLI report extraction
Cleye outputs ANSI bold escape sequences around section headers
(e.g. Usage:, Flags:) unconditionally, which prevented the help
page parser from recognizing them. Strip ANSI SGR sequences from
captured output and set NO_COLOR=1 in the child environment.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 10:45:56 +01:00
Patrik Oldsberg f2a8299d7a repo-tools: Log all command outputs for debugging
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 10:33:15 +01:00
Patrik Oldsberg 3a1054f51d repo-tools: Log stdout content when help markers missing
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 10:21:09 +01:00
Patrik Oldsberg b7c9a8df12 repo-tools: Add module-level debug log to verify util.ts is loaded
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 10:11:23 +01:00
Patrik Oldsberg f586daee1f repo-tools: Add debug logging for empty stdout in createBinRunner
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 09:59:15 +01:00
Patrik Oldsberg 2481126013 Remove setBlocking calls and simplify file-redirect approach
Remove fragile process.stdout._handle.setBlocking calls from CLI test
commands. Revert the preload workaround in repo-tools since the root
cause is removed.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 08:48:19 +01:00
Patrik Oldsberg 5e01ab714a repo-tools: Add _handle stub preload for file-backed stdout
Add a --require preload that stubs process.stdout._handle when stdout is
a SyncWriteStream (file-backed). Some CLI code accesses _handle.setBlocking
directly and would crash without the stub.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 08:46:44 +01:00
Patrik Oldsberg d9dde597c9 repo-tools: Redirect child stdout to file for CLI reports
Use a temp file instead of a pipe for child process stdout in
createBinRunner. Node.js uses a SyncWriteStream for regular files, so
all writes complete synchronously before process.exit() can discard them.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 01:21:53 +01:00
Patrik Oldsberg a2653cd112 Update repo-tools changeset to cover spawnSync change
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 00:08:23 +01:00
Patrik Oldsberg b4fea2bc29 repo-tools: Use spawnSync for CLI report extraction
Use spawnSync instead of spawn for child processes in createBinRunner.
This avoids stdout data loss when child processes call process.exit()
before Node.js flushes its internal stream buffer to the pipe.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 00:08:22 +01:00
Patrik Oldsberg fab449cf9e cli: lint fix
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-02-27 00:08:18 +01:00
Patrik Oldsberg d5779e525c Fix CLI report generation and --help handling for loader-based commands
Add cleye-based --help handling to all commands using the loader pattern.
Update the CLI report parser to support cleye's USAGE: and FLAGS: sections.
Revert accidental backstage.role addition to eslint-plugin.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-26 20:31:55 +01:00
Patrik Oldsberg 0d2d0f2e07 Add lazy loader pattern for CLI command execution
Extend `BackstageCommand.execute` to accept either a direct function or a
`{ loader }` object for lazy loading command implementations. Convert
several build and migrate commands to use the new pattern. Switch from
`program.parse` to `program.parseAsync` to properly await async actions.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-26 19:56:57 +01:00
Fredrik Adelöw c472a693b6 Merge pull request #32986 from backstage/freben/valer
run vale directly instead of through the action
2026-02-26 15:55:13 +01:00
Fredrik Adelöw a22c0a368e use a distinct hash instead
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-02-26 14:45:34 +01:00
Ben Lambert a6b28199e5 feat(catalog): Implement query-catalog-entities on top of the filter predicates (#33022)
* chore: create query catalog
Signed-off-by: benjdlambert <ben@blam.sh>

Signed-off-by: benjdlambert <ben@blam.sh>

* feat(catalog-backend): add query-catalog-entities action

Signed-off-by: benjdlambert <ben@blam.sh>

* fix: address PR review feedback

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: benjdlambert <ben@blam.sh>
2026-02-26 14:45:10 +01:00
Fredrik Adelöw 4e85e7b0b3 Update .github/workflows/verify_docs-quality.yml
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-02-26 14:37:07 +01:00
Fredrik Adelöw 356d1662d8 Update .github/workflows/verify_docs-quality.yml
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-02-26 14:37:07 +01:00
Fredrik Adelöw 0c0f46de09 Update .github/workflows/verify_docs-quality.yml
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-02-26 14:37:07 +01:00
Fredrik Adelöw 2690d416f8 Update scripts/check-docs-quality.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-02-26 14:37:07 +01:00
Fredrik Adelöw b35f3595aa run vale directly instead of through the action
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-02-26 14:37:07 +01:00
Andre Wanlin d419bcff55 Merge pull request #32966 from backstage/renovate/nodemon-3.x-lockfile
chore(deps): update dependency nodemon to v3.1.14
2026-02-26 05:57:27 -06:00
Andre Wanlin c030579e1d Merge pull request #32963 from backstage/renovate/testcontainers-node-monorepo
chore(deps): update dependency testcontainers to v11.12.0
2026-02-26 05:57:00 -06:00
Charles de Dreuille 969540f73d Merge pull request #33002 from backstage/cdedreuille/ui-neutral-bg-simplification
feat(ui): neutral bg system overhaul — single incremental value + overlay reset
2026-02-26 11:56:42 +00:00
Patrik Oldsberg e8c31266c2 Merge pull request #33013 from backstage/rugvip/cli-final-lib-cleanup
cli: eliminate src/lib/ directory and last cross-module import
2026-02-26 10:10:54 +01:00
Ben Lambert 62f0a53d65 Fix error forwarding in actions registry to preserve original status codes (#33021)
Signed-off-by: benjdlambert <ben@blam.sh>
2026-02-26 08:59:58 +00:00
Andre Wanlin c869f0ed9e Merge pull request #33017 from backstage/dependabot/npm_and_yarn/basic-ftp-5.2.0
build(deps): bump basic-ftp from 5.0.3 to 5.2.0
2026-02-25 18:05:01 -06:00
Patrik Oldsberg 5411f0a8f8 remove changeset
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-26 00:03:40 +01:00
dependabot[bot] 3aa4af57ec build(deps): bump basic-ftp from 5.0.3 to 5.2.0
Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.0.3 to 5.2.0.
- [Release notes](https://github.com/patrickjuchli/basic-ftp/releases)
- [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/patrickjuchli/basic-ftp/compare/v5.0.3...v5.2.0)

---
updated-dependencies:
- dependency-name: basic-ftp
  dependency-version: 5.2.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-25 22:57:15 +00:00
Patrik Oldsberg b061a69d14 Merge pull request #33015 from backstage/rugvip/fix-ci-plugin-directory-paths
ci: run CI for changes to microsite/data/
2026-02-25 23:53:00 +01:00
Patrik Oldsberg beab3cc456 cli: eliminate src/lib/ directory and last cross-module import
Split version.ts into two locations:
- Template version provider moved to modules/new/lib/version.ts
- CLI version info moved to wiring/version.ts

Remove publishPreflightCheck from repo fix command (still runs during
package prepack). Fix build module self-references to use shorter
within-module paths.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 23:36:30 +01:00
Patrik Oldsberg c482b2c385 ci: run CI for changes to microsite/data/
The paths-ignore for microsite/** was also skipping CI for changes to
microsite/data/plugins/, which is where the plugin directory YAML files
live. This meant the verify plugin directory step never ran for the
files it was supposed to validate.

Switch from paths-ignore to paths with negation so that microsite/data/
changes still trigger CI while other microsite changes remain excluded.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 23:35:46 +01:00
Patrik Oldsberg 81308aee47 Merge pull request #33014 from backstage/rugvip/fix-plugin-directory-status
microsite: add missing status field to plugin directory entry
2026-02-25 23:33:46 +01:00
Patrik Oldsberg cb6f3907ed microsite: add missing status field to plugin directory entry
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 23:28:48 +01:00
Patrik Oldsberg b2fda888ea Merge pull request #32996 from backstage/rugvip/fix-mui-styles-shared-dep-key
module-federation-common: fix trailing slash in MUI styles shared dependency key
2026-02-25 21:34:28 +01:00
Fredrik Adelöw 54f500813e Merge pull request #32865 from balajisiva/add-template-builder-plugin
Add Template Builder plugin to directory
2026-02-25 21:15:43 +01:00
Fredrik Adelöw 6416384325 Merge pull request #32968 from andreahlert/add-n8n-to-plugin-directory
Add n8n to plugin directory
2026-02-25 21:12:54 +01:00
Fredrik Adelöw 6e37d2984c Merge pull request #33003 from RinkeHoekstra/patch-2
Fix capitalization in resource description
2026-02-25 21:12:14 +01:00
Patrik Oldsberg 0cb56465dd fix(module-federation): remove trailing slash from @mui/material/styles shared dependency key
The shared dependency key `@mui/material/styles/` (with trailing slash) caused
module resolution failures because MUI's package.json exports map only defines
`./styles`, not `./styles/`. This resulted in errors like:

  Package subpath './styles/' is not defined by "exports" in
  @mui/material/package.json

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 21:04:28 +01:00
Andre Wanlin 7bf7026b7b Merge pull request #33011 from awanlin/blog/contribfest-ams
Blog - Get a jump on ContribFest
2026-02-25 14:01:04 -06:00
Patrik Oldsberg ffa520dd3b Merge pull request #33000 from backstage/rugvip/move-cli-utils-to-cli-node
cli-node, cli: move yarnPlugin and SuccessCache to cli-node
2026-02-25 20:50:28 +01:00
Charles de Dreuille 1afa036222 Cleanup
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-02-25 19:46:17 +00:00
Andre Wanlin b6412b1b44 Prettier
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
2026-02-25 13:32:32 -06:00
Patrik Oldsberg fb14783d9b ci: trigger
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-25 20:17:47 +01:00
Patrik Oldsberg 09eb6b5187 Address further review feedback
- Rename hasYarnPlugin -> hasBackstageYarnPlugin for clarity
- Change SuccessCache.create to accept an options object

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 20:17:47 +01:00
Patrik Oldsberg 968570bbb5 Address review feedback
- Remove cli changeset, piggy-back on existing ones
- Rename getHasYarnPlugin -> hasYarnPlugin(workspaceDir?)
- Make SuccessCache constructor private, add static create()
- Consolidate duplicate @backstage/cli-node imports

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 20:17:47 +01:00
Patrik Oldsberg 3c811bf8a9 cli-node, cli: move yarnPlugin and SuccessCache to cli-node
Move `getHasYarnPlugin` and `SuccessCache` from `@backstage/cli` internal
modules to `@backstage/cli-node` as public exports, making them available
for reuse by other CLI tooling.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 20:17:22 +01:00
Patrik Oldsberg dd6408d682 Merge pull request #33005 from backstage/rugvip/entity-content-group-defaults
techdocs, api-docs: add default entity content groups
2026-02-25 20:15:33 +01:00
Patrik Oldsberg a611d22986 Merge pull request #33007 from backstage/rugvip/cli-split-loadCliConfig
cli: split loadCliConfig into separate build and config implementations
2026-02-25 19:52:50 +01:00