Commit Graph

50320 Commits

Author SHA1 Message Date
Alex Crome a0b01eda2c Moved defence against null tokens into defaultProfileTransform to apply more broadly than just Microsoft tokens.
Signed-off-by: Alex Crome <afscrome@users.noreply.github.com>
2024-02-19 15:07:47 +00:00
Alex Crome 8d77d00733 Capatalised 'Microsoft' in changeset
Signed-off-by: Alex Crome <afscrome@users.noreply.github.com>
2024-02-19 14:51:09 +00:00
Alex Crome 71c3b7f765 Fix Microsoft Auth Provider when Profile not requested
Ensure that the Microsoft provider passes an empty profile object down if it hasn't received/requested one from the provider.  Fixes #23032.

The legacy Microsoft provider did something similar to replace a null profile with an empty object. https://github.com/backstage/backstage/blob/96c4f54bf6070db12676e9af0bf75d0d479c3d72/plugins/auth-backend/src/providers/microsoft/provider.ts#L266

I guess the only question is whether we want to fix this specifically for the Microsoft provider, or should we handle a null profiles deeper in the stack (i.e. `PassportOAuthAuthenticatorHelper.defaultProfileTransform` or in `PassportHelpers.transformProfile`)

Reason this didn't affect the legacy backend is that it was only recently the legacy backend Microsoft module was swapped over to use the path from the newer backend - #22208

Signed-off-by: Alex Crome <afscrome@users.noreply.github.com>
2024-02-19 14:40:42 +00:00
Patrik Oldsberg 9b65b814f6 Merge pull request #22856 from backstage/Rugvip-patch-2
OWNERS: add org member deepan10
2024-02-09 16:17:59 +01:00
Patrik Oldsberg 0b856a6bce OWNERS: add org member deepan10
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-09 15:38:48 +01:00
Patrik Oldsberg afa2734865 Merge pull request #22852 from backstage/rugvip/testrefactor
events-backend: refactored test to avoid mocking httpRouter
2024-02-09 13:28:03 +01:00
Patrik Oldsberg 0396dbac52 Merge pull request #22761 from backstage/rugvip/allow-empty
cli: stop requiring configuration for the frontend build
2024-02-09 13:11:54 +01:00
Patrik Oldsberg f33b225505 Merge pull request #22836 from backstage/rugvip/secret
integrations: trim secrets read from config
2024-02-09 13:11:39 +01:00
Patrik Oldsberg a6c78b8f15 events-backend: refactored test to avoid mocking httpRouter
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-09 13:08:15 +01:00
Patrik Oldsberg 1c9d757605 Merge pull request #22840 from backstage/rugvip/bep3-updates
beps/0003: updates to align with experimental design
2024-02-09 11:03:20 +01:00
Ben Lambert 262644b255 Merge pull request #22831 from backstage/renovate/git-url-parse-14.x
fix(deps): update dependency git-url-parse to v14
2024-02-09 09:40:29 +01:00
Patrik Oldsberg 957317e928 Merge pull request #22835 from backstage/rugvip/dbm
backend-{common,tasks}: stop depending on full DatabaseManager type
2024-02-09 00:22:17 +01:00
Patrik Oldsberg 67072166a9 backend-{common,tasks}: stop depending on full DatabaseManager type
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 22:11:15 +01:00
Patrik Oldsberg b245b97e8c Merge pull request #22841 from backstage/rugvip/e2e-test-react17
e2e-test: add test for backwards compatibility with React 17
2024-02-08 20:08:42 +01:00
Patrik Oldsberg 7ca20761e9 e2e-test: add test for backwards compatibility with React 17
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 18:37:07 +01:00
Patrik Oldsberg 40a1b52f58 beps/0003: updates to align with experimental design
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 18:13:12 +01:00
Patrik Oldsberg 52941b2639 Merge pull request #22588 from backstage/philipph/docs-builtin-data-refs
Add docs for build-in data refs to plugin docs
2024-02-08 12:27:28 +01:00
Patrik Oldsberg 9cb48966b8 Apply suggestions from code review
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 12:27:05 +01:00
Patrik Oldsberg 6d898f71ea integrations: trim secrets read from config
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 12:19:53 +01:00
Fredrik Adelöw bb50cfabbe Merge pull request #22832 from backstage/freben/knipx
updated the knip rules a bit
2024-02-08 11:32:40 +01:00
Fredrik Adelöw 4c49b15de1 knip files should be owned just by us
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-02-08 11:30:10 +01:00
Patrik Oldsberg 8b5ac7a925 Merge pull request #22471 from backstage/camilaibs/building-new-frontend-apps
[DI] Add building apps and built-in extensions docs
2024-02-08 09:54:34 +01:00
Fredrik Adelöw e97cc0b0a3 updated the knip rules a bit
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-02-08 09:53:18 +01:00
Fredrik Adelöw 8afb5c6671 Merge pull request #21963 from drodil/introduce_knip
ci: introduce knip for checking unused packages
2024-02-08 09:19:16 +01:00
renovate[bot] 1cae748519 fix(deps): update dependency git-url-parse to v14
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-08 08:10:53 +00:00
Ben Lambert eb46a3ff75 Merge pull request #22824 from backstage/renovate/ruby-3.3
chore(deps): update ruby:3.3 docker digest to 6936c28
2024-02-08 08:25:30 +01:00
Ben Lambert c15a2bb0be Merge pull request #22815 from backstage/renovate/swc-monorepo
fix(deps): update swc monorepo
2024-02-08 08:20:13 +01:00
Ben Lambert 9a65ceff1e Merge pull request #22800 from backstage/rugvip/repofix
cli: add repository field check to the repo fix command
2024-02-08 08:11:50 +01:00
Heikki Hellgren c9d39120b2 chore: update knip reports
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 09:08:32 +02:00
renovate[bot] 563e7e4008 chore(deps): update ruby:3.3 docker digest to 6936c28
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-08 06:39:10 +00:00
Heikki Hellgren 749c17d3a8 fix: wrong husky version
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 08:38:05 +02:00
Heikki Hellgren 23a29697aa ci: introduce knip for checking unused packages
fixes #21948

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 08:38:05 +02:00
Heikki Hellgren 00175d889a docs: update knip reports
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 08:37:55 +02:00
Heikki Hellgren 55963c4714 feat: move knip reports under own command
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 08:29:50 +02:00
Heikki Hellgren e5a84943f2 chore: update to knip 4
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 08:29:50 +02:00
Fredrik Adelöw b38d6b1e66 parallelize
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-02-08 08:29:50 +02:00
Heikki Hellgren 60a68f10e9 ci: introduce knip for checking unused packages
fixes #21948

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 08:29:48 +02:00
Jamie Klassen 216fce4b2c Merge pull request #22614 from armandocomellas1/master
[Google Kubernetes Engine] Add x-goog-api-client header with custom values
2024-02-07 22:16:24 -05:00
backstage-goalie[bot] 128fdcf640 Merge pull request #22820 from backstage/renovate/google-cloud-container-5.x-lockfile
fix(deps): update dependency @google-cloud/container to v5.6.0
2024-02-08 00:42:52 +00:00
Patrik Oldsberg 847218837d add missing repository fields
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 01:17:10 +01:00
Patrik Oldsberg d557d47cb5 cli: added repository field check to repo fix
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 01:14:44 +01:00
renovate[bot] e12086e487 fix(deps): update dependency @google-cloud/container to v5.6.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-08 00:12:52 +00:00
backstage-goalie[bot] c641dae287 Merge pull request #22715 from backstage/renovate/react-hook-form-7.x-lockfile
fix(deps): update dependency react-hook-form to v7.50.1
2024-02-07 23:59:09 +00:00
Armando Comellas 94fe336f98 Merge branch 'backstage:master' into master 2024-02-07 23:19:21 +00:00
Patrik Oldsberg 4015923bae Merge pull request #22729 from backstage/renovate/react-hookz-web-24.x
fix(deps): update dependency @react-hookz/web to v24
2024-02-08 00:11:59 +01:00
Armando Comellas d782a23668 Merge branch 'backstage:master' into master 2024-02-07 23:02:50 +00:00
Patrik Oldsberg 9aec6cff51 Merge pull request #22817 from backstage/renovate/dompurify-3.x
fix(deps): update dependency dompurify to v3
2024-02-07 23:48:21 +01:00
backstage-goalie[bot] 117d1c1203 Merge pull request #22816 from backstage/renovate/typescript-eslint-monorepo
fix(deps): update typescript-eslint monorepo to v6.21.0
2024-02-07 22:45:05 +00:00
renovate[bot] 09cedb9ae8 fix(deps): update dependency @react-hookz/web to v24
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-07 22:25:14 +00:00
renovate[bot] 3631fb4c1a fix(deps): update dependency dompurify to v3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-07 22:18:24 +00:00