Fredrik Adelöw
b9436b2ca4
Merge pull request #9693 from sakkshm26/docs
...
Fix typos in docs
2022-02-22 13:39:20 +01:00
Ben Lambert
53dbebbcde
Merge pull request #9701 from backstage/blam/deprecations/octokit
...
deprecations: Deprecate the `OctokitProvider` export from `scaffolder-backend`
2022-02-22 13:38:32 +01:00
blam
dbe239808d
chore: encodeURIComponent
...
Signed-off-by: blam <ben@blam.sh >
diff --git c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
index ca70084ef5..9efc11210a 100644
--- c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
+++ i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
@@ -65,10 +65,14 @@ export const defaultClientFactory = async ({
host = 'github.com',
token: providedToken,
}: ClientFactoryInput): Promise<PullRequestCreator> => {
+ const [encodedHost, encodedOwner, encodedRepo] = [host, owner, repo].map(
+ encodeURIComponent,
+ );
+
const octokitOptions = await getOctokitOptions({
integrations,
credentialsProvider: githubCredentialsProvider,
- repoUrl: `https://${host}/${owner}/${repo} `,
+ repoUrl: `https://${encodedHost}/${encodedOwner}/${encodedRepo} `,
token: providedToken,
});
2022-02-22 13:10:39 +01:00
Fredrik Adelöw
d4121a54e3
Merge pull request #9722 from backstage/freben/tasks-janitor
...
backend-tasks: no unnecessary janitor log output on sqlite
2022-02-22 12:16:21 +01:00
Fredrik Adelöw
baea75b11a
Merge pull request #9723 from backstage/freben/airbrake-optional
...
airbrake: fix config to be optional, unbreak local dev startup
2022-02-22 11:50:39 +01:00
MT Lewis
42719ffa55
Merge pull request #9705 from backstage/optional-backend-auth
...
backend-common: make backend.auth.keys optional in config schema
2022-02-22 10:48:48 +00:00
Fredrik Adelöw
0045270527
airbrake: fix config to be optional, unbreak local dev startup
...
Signed-off-by: Fredrik Adelöw <freben@gmail.com >
2022-02-22 11:31:05 +01:00
blam
8142c09b3f
chore: wth prettier
...
Signed-off-by: blam <ben@blam.sh >
2022-02-22 11:29:35 +01:00
Fredrik Adelöw
dc97845422
backend-tasks: no unnecessary janitor log output on sqlite
...
Signed-off-by: Fredrik Adelöw <freben@gmail.com >
2022-02-22 11:27:53 +01:00
Saksham Sharma
3791961a4a
Add the requested changes
...
Signed-off-by: Saksham Sharma <sakshamsharma630@gmail.com >
2022-02-22 15:45:36 +05:30
Saksham Sharma
5c58400dfe
Fix a typo in CONTRIBUTING.md
...
Signed-off-by: Saksham Sharma <sakshamsharma630@gmail.com >
2022-02-22 15:33:03 +05:30
Saksham Sharma
e7d2599d35
Update the docs
...
Signed-off-by: Saksham Sharma <sakshamsharma630@gmail.com >
2022-02-22 15:33:03 +05:30
Fredrik Adelöw
7ee2f47049
Merge pull request #9710 from backstage/dependabot/npm_and_yarn/graphql-codegen/typescript-2.4.5
...
chore(deps-dev): bump @graphql-codegen/typescript from 2.4.2 to 2.4.5
2022-02-22 10:00:08 +01:00
Fredrik Adelöw
334ce2314a
Merge pull request #9716 from backstage/dependabot/npm_and_yarn/types/humanize-duration-3.27.1
...
chore(deps-dev): bump @types/humanize-duration from 3.25.1 to 3.27.1
2022-02-22 09:59:37 +01:00
Johan Haals
1d8e0be327
Merge pull request #9713 from backstage/dependabot/npm_and_yarn/vm2-3.9.8
...
chore(deps): bump vm2 from 3.9.7 to 3.9.8
2022-02-22 09:59:14 +01:00
Johan Haals
b734f71362
Merge pull request #9717 from backstage/dependabot/npm_and_yarn/changesets/cli-2.21.0
...
chore(deps-dev): bump @changesets/cli from 2.20.0 to 2.21.0
2022-02-22 09:41:56 +01:00
Johan Haals
1fe62554bc
Merge pull request #9712 from backstage/dependabot/npm_and_yarn/types/color-3.0.3
...
chore(deps-dev): bump @types/color from 3.0.2 to 3.0.3
2022-02-22 09:02:17 +01:00
Johan Haals
43438cd8c7
Merge pull request #9715 from backstage/dependabot/npm_and_yarn/types/xml2js-0.4.9
...
chore(deps-dev): bump @types/xml2js from 0.4.8 to 0.4.9
2022-02-22 09:01:57 +01:00
dependabot[bot]
c03f71a4cc
chore(deps-dev): bump @changesets/cli from 2.20.0 to 2.21.0
...
Bumps [@changesets/cli](https://github.com/changesets/changesets ) from 2.20.0 to 2.21.0.
- [Release notes](https://github.com/changesets/changesets/releases )
- [Changelog](https://github.com/changesets/changesets/blob/main/docs/modifying-changelog-format.md )
- [Commits](https://github.com/changesets/changesets/compare/@changesets/cli@2.20.0...@changesets/cli@2.21.0 )
---
updated-dependencies:
- dependency-name: "@changesets/cli"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-22 04:34:41 +00:00
dependabot[bot]
d733bf633a
chore(deps-dev): bump @types/humanize-duration from 3.25.1 to 3.27.1
...
Bumps [@types/humanize-duration](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/humanize-duration ) from 3.25.1 to 3.27.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/humanize-duration )
---
updated-dependencies:
- dependency-name: "@types/humanize-duration"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-22 04:23:30 +00:00
dependabot[bot]
f2dfc04607
chore(deps-dev): bump @types/xml2js from 0.4.8 to 0.4.9
...
Bumps [@types/xml2js](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/xml2js ) from 0.4.8 to 0.4.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/xml2js )
---
updated-dependencies:
- dependency-name: "@types/xml2js"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-22 04:21:14 +00:00
dependabot[bot]
37bcc9ec52
chore(deps): bump vm2 from 3.9.7 to 3.9.8
...
Bumps [vm2](https://github.com/patriksimek/vm2 ) from 3.9.7 to 3.9.8.
- [Release notes](https://github.com/patriksimek/vm2/releases )
- [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/patriksimek/vm2/compare/3.9.7...3.9.8 )
---
updated-dependencies:
- dependency-name: vm2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-22 04:15:17 +00:00
dependabot[bot]
02473f82a6
chore(deps-dev): bump @types/color from 3.0.2 to 3.0.3
...
Bumps [@types/color](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/color ) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/color )
---
updated-dependencies:
- dependency-name: "@types/color"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-22 04:13:10 +00:00
dependabot[bot]
63dc066dcd
chore(deps-dev): bump @graphql-codegen/typescript from 2.4.2 to 2.4.5
...
Bumps [@graphql-codegen/typescript](https://github.com/dotansimha/graphql-code-generator/tree/HEAD/packages/plugins/typescript/typescript ) from 2.4.2 to 2.4.5.
- [Release notes](https://github.com/dotansimha/graphql-code-generator/releases )
- [Changelog](https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/typescript/CHANGELOG.md )
- [Commits](https://github.com/dotansimha/graphql-code-generator/commits/@graphql-codegen/typescript@2.4.5/packages/plugins/typescript/typescript )
---
updated-dependencies:
- dependency-name: "@graphql-codegen/typescript"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-22 04:06:43 +00:00
Fredrik Adelöw
d788fa8495
Merge pull request #9665 from djamaile/feature-flag-scaffolding
...
feat(scaffolder): remove sections or fields based on a feature flag
2022-02-21 21:53:40 +01:00
blam
5b7079a696
chore review comments
...
Signed-off-by: blam <ben@blam.sh >
Signed-off-by: blam <ben@blam.sh >
2022-02-21 20:52:27 +01:00
djamaile
04d4829cf4
refactor: respond to comments #2
...
Signed-off-by: djamaile <rdjamaile@gmail.com >
2022-02-21 20:26:54 +01:00
Fredrik Adelöw
b212bed480
Merge pull request #9605 from moltenice-forks/airbrake-connect
...
Make the Airbrake plugin useable
2022-02-21 19:49:03 +01:00
Mike Lewis
b2f8bb99d3
backend-common: make configuration objects optional in config schema
...
The previous schema meant that if any other plugin introduced something
under backend.auth, the keys property would be mandatory, which isn't
correct. This commit relaxes the requirement so that backend.auth.keys
is always optional, even if backend.auth is configured.
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com >
2022-02-21 18:30:00 +00:00
Eric Peterson
78e31e6b68
Merge pull request #9244 from jonathan-ash/techdocs-reader-custom-error-page
...
Added the option to supply a custom error page to TechDocsPage
2022-02-21 17:50:03 +01:00
Eric Peterson
3675e7120c
Minor feedback
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-02-21 17:12:50 +01:00
Fredrik Adelöw
1b7d5e5bea
Merge pull request #9686 from backstage/dependabot/npm_and_yarn/graphql-modules-2.0.0
...
chore(deps): bump graphql-modules from 1.4.4 to 2.0.0
2022-02-21 16:59:39 +01:00
Karan Shah
96e8c9fd59
Refactor to not need core-app-api
...
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk >
2022-02-21 15:38:07 +00:00
djamaile
5c5362137a
refactor: respond to comments
...
Signed-off-by: djamaile <rdjamaile@gmail.com >
2022-02-21 16:30:04 +01:00
Johan Haals
ac27092211
Merge pull request #9698 from backstage/jhaals/cleanup-catalog-backend
...
catalog-backend: Cleanup API report
2022-02-21 16:14:31 +01:00
blam
b1744f1153
chore: added changeset
...
Signed-off-by: blam <ben@blam.sh >
2022-02-21 16:13:07 +01:00
blam
5042a822f6
chore: fix auth provided
...
Signed-off-by: blam <ben@blam.sh >
2022-02-21 16:08:16 +01:00
blam
1a864a3b68
chore: updating the api report
...
Signed-off-by: blam <ben@blam.sh >
2022-02-21 15:57:18 +01:00
Emma Indal
f6666642d2
Merge pull request #9546 from backstage/emmaindal/techdocs-cli-tests
...
[TechDocs CLI] adding cypress testing
2022-02-21 15:54:53 +01:00
blam
9553964f28
chore: providing a new helper for generating octokit credentialsProvider
...
Signed-off-by: blam <ben@blam.sh >
2022-02-21 15:41:30 +01:00
blam
afee525a36
chore: deprecating the OctokitProvider
...
Signed-off-by: blam <ben@blam.sh >
2022-02-21 15:40:38 +01:00
Karan Shah
f62ce97a15
This is needed
...
https://github.com/backstage/backstage/runs/5275475872?check_suite_focus=true
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk >
2022-02-21 14:33:09 +00:00
Karan Shah
4abc806f23
Remove unnecessary dependency
...
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk >
2022-02-21 14:15:23 +00:00
Karan Shah
c9e1ebed25
No need for this as it isn't actually enabled anyway
...
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk >
2022-02-21 14:13:53 +00:00
Ben Lambert
416032660b
Merge pull request #9670 from backstage/blam/deprecations/3
...
deprecations: More small type fixes and deprecations for `scaffolder-backend`
2022-02-21 15:01:12 +01:00
Fredrik Adelöw
92f8b539f1
Merge pull request #9674 from djamaile/feat/link-log-lines
...
feat(core-components): add line linking in the log viewer
2022-02-21 15:00:09 +01:00
Fredrik Adelöw
c503e588b5
Merge pull request #9673 from backstage/server-permission-client-error
...
[Permissions] Improve error message for backend-to-backend authn setup
2022-02-21 14:59:01 +01:00
Johan Haals
750f7dffdb
Merge pull request #9695 from backstage/jhaals/deprecate-useEntityListProvider
...
catalog-react: Rename useEntityListProvider hook to useEntityList
2022-02-21 14:57:49 +01:00
Fredrik Adelöw
7c4a51ae0e
Merge pull request #9640 from backstage/dependabot/npm_and_yarn/asyncapi/react-component-1.0.0-next.33
...
chore(deps): bump @asyncapi/react-component from 1.0.0-next.32 to 1.0.0-next.33
2022-02-21 14:56:05 +01:00
Johan Haals
6d994fd9da
catalog-backend: Cleanup API report
...
Signed-off-by: Johan Haals <johan.haals@gmail.com >
2022-02-21 14:55:34 +01:00