Commit Graph

45579 Commits

Author SHA1 Message Date
AmbrishRamachandiran c6e7940ccf updated readme document in bazaar plugin
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2023-10-26 12:24:54 +05:30
Fredrik Adelöw 78bc50af22 Merge pull request #19881 from Abhay-soni-developer/jenkins/jobrun-table
jenkins JobRunTable added
2023-10-14 17:10:22 +02:00
Jamie Klassen e0b5cd9fdb Merge pull request #19846 from RubenV-dev/pinniped-auth
Pinniped Auth Provider
2023-10-13 11:36:24 -04:00
Patrik Oldsberg 0a942585a7 Merge pull request #20522 from Naycon/remove-mock-fs-usage-from-cli-package
Replace mock-fs with createMockDirectory in the cli packages.
2023-10-13 16:55:16 +02:00
Patrik Oldsberg 98c85c6077 Merge pull request #20596 from backstage/rugvip/react-18-compat
dev-utils,techdocs: add conditional support for React 18
2023-10-13 16:40:17 +02:00
Patrik Oldsberg 9468a67b92 dev-utils,techdocs: add conditional support for React 18
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-13 16:06:21 +02:00
Patrik Oldsberg e1bf2a5531 Merge pull request #20575 from backstage/rugvip/react18
type fixes for React 18
2023-10-13 16:03:42 +02:00
Ben Lambert f347782b9d Merge pull request #20585 from backstage/blam/scaffolder-owner 2023-10-13 13:51:57 +02:00
Patrik Oldsberg 28b22b5a6f Merge pull request #20587 from backstage/rugvip/cwdfix
create-app: fix for test not restoring cwd
2023-10-13 11:25:20 +02:00
Patrik Oldsberg 0296f272b4 type fixes for React 18
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-13 11:24:00 +02:00
Patrik Oldsberg 29f2e76b51 create-app: fix for test not restoring cwd
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-13 11:05:56 +02:00
blam 49678f0002 feat: added scaffolder maintainers to the codeowners
Signed-off-by: blam <ben@blam.sh>
2023-10-13 10:15:01 +02:00
Patrik Oldsberg b2817daf0c Merge pull request #20562 from backstage/rugvip/legacy
changesets: tweak changeset for backend start change
2023-10-12 16:56:34 +02:00
Patrik Oldsberg c96beb00e7 Merge pull request #20567 from gashcrumb/update-change-handler
fix: Tidy up i18nextTranslationApi change handling
2023-10-12 16:33:10 +02:00
Ruben Vallejo 2f172ba927 remove pinniped provider from default providers in auth-backend
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:25:18 -04:00
Ruben Vallejo b497b6e9f3 Extract rfc8693 tokenexchange logic to a helper function
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
Co-authored-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:13:40 -04:00
Ruben Vallejo ae34255836 PR chores: changeset, api-report, cleaning, add catalog-info entry
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 362a5e293f Completed Pinniped Authenticator refactor with passing unit tests
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 501a8b5bad WIP: new auth pattern refactor, intro module and authenticator tests, #start refactor complete
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Jamie Klassen 8d3e9c7277 clean up tests
and remove tokenSignedAlg option from pinniped, since it's not actually
configurable by end users. This means that all the tests use ID tokens signed
with a real JWK.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 70a3c2631f resolve rebase type/compilation errors
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 5ee7c789ad refactor provider unit tests
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo f5be2ec692 Add rfc token exchange logic to #handler success
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo eb1dac4d84 Change handler to return scope returned by the tokenset
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 448ff7b10b add offline_access scope to default scope list in #start
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 44483b9a0a refactor and add #refresh to pinnipedAuth provider
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 9fedd45be6 introduce audience parameter into start method and pass it into oauth state, fix integration tests
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 07dcd84379 Add redirect and error methods to the handlers strategy along with unit tests
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo ae059825ce Provider requests scopes
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Ruben Vallejo 7dc7a38f3f authorization code exchange for a valid access_token
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Jamie Klassen b6f103de19 working integration test
Some thoughts at this point:
* it would be nice to gather all the fakePinnipedSupervisor setup together
  in the beforeEach rather than spreading it throughout the test body
* we need a real JWK/JWKS endpoint for token signing

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
Co-authored-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:55 -04:00
Jamie Klassen c1c062ad69 refine requirements for start method
Now the unit tests for the start method should render the '#start' describe
in index.test.ts redundant.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
Co-authored-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen 7c26171d2a refactor: minimal passing implementation
Removed all the code that wasn't impacting a failing test, and removed the
"ID token" test -- we'll start with access tokens since they are more important
for our token-exchange use case.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
Co-authored-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Ruben Vallejo 295dae8ab5 passing pinniped authprovider #handler responds with Id token test
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Ruben Vallejo 07df9ce153 implement consent redirect in new PinnipedAuthProvider
Signed-off-by: Ruben Vallejo <rvallejo@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen 7b4b8a0034 wip: auth-backed performs rfc 8693 token exchange
Just driving with the test at this point, hitting some trouble with
express-session/cookies but I have an idea for an approach when I return to it:

Hopefully it will be enough to enable all the right middlewares in our
express app under test and then use `request.agent` from supertest as in

https://github.com/ladjs/supertest/blob/25920e7a1d246b590123417bfce33221db88e947/README.md?plain=1#L244-L256

which can make an initial request to the `/start` endpoint and persist cookies
to the next request (the interesting one under test) to `/handler/frame`.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen 50223e7744 WIP: conditionally skip user profile
OIDC auth provider returns an empty user profile when the associated issuer has
no userinfo_endpoint. In theory this would enable access-delegation-only use
cases, but I haven't thought through all the consequences.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:54 -04:00
Jamie Klassen d4cdf46e49 extract pinniped auth provider
a modified copy of the oidc auth provider, with a slight change in config
schema. A single high-level integration test checks this.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2023-10-12 10:12:54 -04:00
Patrik Oldsberg b535298539 Update .changeset/shiny-birds-melt.md
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-10-12 16:10:13 +02:00
Fredrik Adelöw 4468f80666 Merge pull request #20568 from backstage/freben/ghpage
Request slightly smaller pages from GitHub
2023-10-12 16:00:10 +02:00
Philipp Hugenroth f29a5d7ce8 Merge pull request #20019 from backstage/philipph/techdocs-di
Migrate TechDocs to new Frontend System
2023-10-12 15:55:02 +02:00
Stan Lewis f1b349cfba fix: Tidy up i18nextTranslationApi change handling
This change removes some extra logic in i18NextTranslationApi's change
handling to ensure it always updates subscribers when a language change
is handled.  The relevant test was updated so it doesn't expect
snapshots that aren't loaded.  Fixes #20381

Signed-off-by: Stan Lewis <gashcrumb@gmail.com>
2023-10-12 09:10:46 -04:00
Djam 002c9562a6 Merge pull request #20394 from fedy97/hotfix/max-length-search-query
fix: max term length prevents backend to crash
2023-10-12 15:07:52 +02:00
Fredrik Adelöw 4f16e60e6d Request slightly smaller pages from GitHub
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-10-12 15:00:06 +02:00
Fredrik Adelöw 8829a84b05 Merge pull request #20547 from Pike/dev-utils-devdeps
Make dev dependencies just devDependencies in dev-utils
2023-10-12 14:32:17 +02:00
backstage-goalie[bot] 3bfb2bf5da Merge pull request #20563 from backstage/renovate/sass-1.x-lockfile
fix(deps): update dependency sass to v1.69.3
2023-10-12 10:40:30 +00:00
Philipp Hugenroth cb0da26467 Update .changeset/modern-owls-mate.md
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Philipp Hugenroth <tudi2d@users.noreply.github.com>
2023-10-12 12:09:43 +02:00
Fredrik Adelöw 41381ddf1b Update .changeset/red-baboons-warn.md
Co-authored-by: Philipp Hugenroth <tudi2d@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-10-12 12:04:39 +02:00
renovate[bot] d8841fcef1 fix(deps): update dependency sass to v1.69.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-12 09:17:10 +00:00
backstage-goalie[bot] 546754dc6a Merge pull request #20560 from backstage/renovate/jose-4.x-lockfile
fix(deps): update dependency jose to v4.15.3
2023-10-12 09:14:04 +00:00