Commit Graph

70938 Commits

Author SHA1 Message Date
Patrik Oldsberg c7d2bf99ee Merge pull request #33001 from backstage/rugvip/cli-lockfile-consolidation
cli-node: consolidate Lockfile and versioning utilities
2026-02-25 14:51:59 +01:00
Fredrik Adelöw 687094dc6f Merge pull request #32874 from backstage/benjdlambert/fix-predicate-review-feedback
`feat(catalog)`: support entity predicate filtering
2026-02-25 14:51:38 +01:00
Patrik Oldsberg a92ae1eb42 Merge pull request #32987 from backstage/rugvip/cli-common-path-cleanup
cli-common: clean up path utils follow-up
2026-02-25 14:27:29 +01:00
Patrik Oldsberg 5033936401 Keep versioning utilities internal to CLI migrate module
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 14:09:25 +01:00
Patrik Oldsberg c2b4ecc73b Merge pull request #32998 from backstage/rugvip/cli-lazy-errors-to-wiring
cli: move lazy.ts and errors.ts to wiring/
2026-02-25 13:57:17 +01:00
Fredrik Adelöw 03f6353954 Merge pull request #32997 from backstage/djam/github-emails
feat(catalog-backend-module-github): prefer verified org emails in default user transformer
2026-02-25 13:20:37 +01:00
Patrik Oldsberg 61cb976207 Consolidate Lockfile classes: move toString() and versioning utils to cli-node
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 11:59:30 +01:00
Patrik Oldsberg 86c424fa8e chore(cli): move lazy.ts and errors.ts to wiring/
These are CLI framework infrastructure files that belong alongside
createCliPlugin and CliInitializer rather than in the general lib/
directory.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 11:43:38 +01:00
djamaile b11c2cd8e2 feat(catalog-backend-module-github): prefer verified org emails in default user transformer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: djamaile <rdjamaile@gmail.com>
2026-02-25 11:34:06 +01:00
Charles de Dreuille 51fc8a0fd4 Merge pull request #32984 from backstage/cdedreuille/ui-guidelines-cards-with-table
feat(ui): add Guidelines section with Cards + Table page layout story
2026-02-25 10:33:21 +00:00
Patrik Oldsberg 3c605eb319 Merge pull request #32995 from backstage/rugvip/move-clean-pack-to-build
cli: move clean and pack commands to build module
2026-02-25 11:32:18 +01:00
Patrik Oldsberg 98faba9d21 changeset: simplify message to internal refactor
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 11:17:54 +01:00
Charles de Dreuille e1c87b33ca Improve modes
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-02-25 10:15:28 +00:00
Patrik Oldsberg 825c81dcde cli: move clean and pack commands to build module
Move the `package clean`, `package prepack`, `package postpack`, and
`repo clean` commands from the internal maintenance module to the build
module, along with the publishing preflight check utility.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-25 10:36:36 +01:00
Johan Persson b42fcdca2e feat(ui): replace --bui-bg-popover with layered bg approach
Remove the --bui-bg-popover token and adopt a two-layer background
pattern across overlay components: outer shell uses --bui-bg-app,
inner content uses Box bg="neutral-1".

Components updated: Popover, Tooltip, Menu, Dialog.

Each component gets a local border-radius CSS variable, a Box
content wrapper with neutral-1 background, and updated arrow
fills where applicable.

Story "is open" variants for each component now use a dot-grid
background pattern to detect background transparency issues in
Chromatic snapshots.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-02-25 09:52:31 +01:00
Charles de Dreuille bf14b6e877 Update chatty-wasps-sink.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-02-25 08:38:35 +00:00
Fredrik Adelöw ba3e15fefb Merge pull request #32991 from backstage/dependabot/npm_and_yarn/minimatch-10.2.3 2026-02-25 08:28:34 +01:00
dependabot[bot] 2e1f98b687 build(deps): bump minimatch from 3.1.2 to 10.2.3
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 10.2.3.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](https://github.com/isaacs/minimatch/compare/v3.1.2...v10.2.3)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 10.2.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-02-25 05:24:30 +00:00
Patrik Oldsberg c7eb58261d Update .changeset/clean-up-own-root-dir.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-24 23:55:15 +01:00
Patrik Oldsberg 59824058ff retrigger CI
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-24 22:21:11 +01:00
Patrik Oldsberg 867d461762 Merge pull request #32985 from backstage/rugvip/agents-md
repo: migrate to AGENTS.md
2026-02-24 22:11:25 +01:00
Patrik Oldsberg 560f587645 repo: symlink .claude/CLAUDE.md to AGENTS.md
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-24 21:57:52 +01:00
Patrik Oldsberg e44b6a9079 cli-common: Remove unused findOwnDir and validate findOwnRootDir
Addresses review feedback from PR #32939:
- Remove the `findOwnDir` function which is no longer needed
- Add validation to `findOwnRootDir` to verify the resolved path
  actually contains a monorepo root with a `package.json` that has
  a `workspaces` field

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-24 21:56:35 +01:00
Patrik Oldsberg 9657061e64 Apply suggestions from code review
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-24 21:50:16 +01:00
Patrik Oldsberg 614f524ace AGENTS.md: minor for significant changes only
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-24 21:48:12 +01:00
Patrik Oldsberg 60cdf5b80c repo: expand AGENTS.md with additional guidelines
Add coding style, testing, changeset, and PR template guidelines.
Remove the now-redundant .claude/CLAUDE.md pointer file.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-24 21:14:27 +01:00
Patrik Oldsberg 410e867616 AGENTS.md: some more pointers for changesets and code style
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-24 21:12:09 +01:00
Patrik Oldsberg 6a1c9550b5 repo: migrate to AGENTS.md
Move agent instructions from `.github/copilot-instructions.md` to `AGENTS.md`
at the repo root for broader AI agent tool compatibility, and remove the
Cursor rule that pointed at the old file.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-24 21:02:50 +01:00
Fredrik Adelöw 23c62214fa Merge pull request #32892 from backstage/changeset-release/master
Version Packages (next)
2026-02-24 20:55:25 +01:00
github-actions[bot] 4bd6a3a1af Version Packages (next) 2026-02-24 19:24:06 +00:00
Charles de Dreuille b5fae74055 Update preview.tsx
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-02-24 19:07:59 +00:00
Charles de Dreuille 4c2c350490 Create chatty-wasps-sink.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-02-24 19:05:25 +00:00
Charles de Dreuille 798fea1218 feat(ui): add Guidelines section with Cards + Table page layout story
- Add `packages/ui/src/guidelines/CardsWithTable.stories.tsx` as the
  first guideline story, showing three data-driven metric cards in a
  3-column grid above a paginated table of catalog services.
- Update Storybook `storySort` order so the new `Guidelines` group
  appears at the top of the `Backstage UI` section.
- Wrap story content in a `Box bg="neutral-1"` when the Spotify theme
  is active, preserving `layout: centered` centering and always
  applying `borderRadius`.
- Import `Box` from the UI package into the Storybook preview.
- Remove `transition` from `Container` CSS to avoid animation on resize.
- Set `padding-inline: 0` on `.bui-Container` inside the Spotify theme
  so containers render flush within the themed wrapper.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-24 18:57:56 +00:00
Johan Persson 890935951b fix(ui): CSS accessibility fixes for Menu, Select, and RadioGroup (#32983)
* fix(ui): add focus-visible outlines to Menu and Select

Replace the default browser focus-visible outline with a
consistent ring style using the data-focus-visible attribute
on Menu items and Select options.

Signed-off-by: Johan Persson <johanopersson@gmail.com>

* fix(ui): add cursor styles to RadioGroup items

Add pointer cursor to radio items and not-allowed cursor
for readonly state.

Signed-off-by: Johan Persson <johanopersson@gmail.com>

---------

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-02-24 17:28:32 +01:00
Ben Lambert dc81af158f feat(mcp-actions): add server operation and session duration metrics (#32978)
Signed-off-by: Kurt King <kurtaking@gmail.com>
Co-authored-by: Kurt King <kurtaking@gmail.com>
2026-02-24 16:18:02 +00:00
Ben Lambert 1ee5b28e41 feat(metrics): Implement MetricsService (#32977)
* feat: add MetricsService alpha release

Introduces MetricsService as a new @alpha core service wrapping
@opentelemetry/api. Includes migration of existing catalog metrics
to use the new service.

Signed-off-by: benjdlambert <ben@blam.sh>

* chore: duplicate otel types, add plugin-scoped factory and tests

Signed-off-by: benjdlambert <ben@blam.sh>

* chore: update BEP-0012 metrics service design

Signed-off-by: Kurt King <kurtaking@gmail.com>

* chore: address PR feedback from freben and rugvip

Rename instrument types with MetricsService prefix for namespace
clarity, move config to backend.metrics.plugin.{pluginId}, add
config.d.ts schema, and improve factory test assertions.

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: benjdlambert <ben@blam.sh>
Signed-off-by: Kurt King <kurtaking@gmail.com>
Co-authored-by: Kurt King <kurtaking@gmail.com>
2026-02-24 16:57:02 +01:00
Fredrik Adelöw 11c4e69eb7 Merge pull request #32946 from backstage/freben/scm-metrics
catalog: add metrics to the SCM events handling
2026-02-24 13:38:17 +01:00
Patrik Oldsberg 1176eb0540 Merge pull request #32939 from backstage/rugvip/cli-module-local-paths
cli-common: new path utils that simplifies use in dependencies
2026-02-24 13:09:35 +01:00
Patrik Oldsberg fd9159f4e5 Merge pull request #32894 from backstage/rugvip/stable-translation-api
frontend-plugin-api: stabilize translation API
2026-02-24 12:02:00 +01:00
Patrik Oldsberg d2af65b1e0 Merge pull request #32975 from backstage/rugvip/remove-applied-patches
chore: remove applied patch files
2026-02-24 11:42:45 +01:00
Fredrik Adelöw 3eb1e79a8b Merge pull request #32973 from johnphilip283/search-on-first-navigate
perform search on first navigate
2026-02-24 09:41:47 +01:00
John Philip 1e8fdd338c add patch
Signed-off-by: John Philip <jphilip@spotify.com>
2026-02-24 03:25:07 -05:00
John Philip d5eb954544 changeset
Signed-off-by: John Philip <jphilip@spotify.com>
2026-02-24 03:20:29 -05:00
Patrik Oldsberg 48235027e4 chore: remove applied patch files
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-24 00:32:29 +01:00
John Philip 5cefb88bb2 perform search on first navigate
Signed-off-by: John Philip <jphilip@spotify.com>
2026-02-23 16:30:33 -05:00
Patrik Oldsberg 2a515460e8 Fix prettier existence checks and import order
Use fs.pathExists instead of checking resolved path strings which are
always truthy. Fix import ordering in e2e-test runCommand.ts.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-23 22:08:37 +01:00
Patrik Oldsberg 909c742c18 Stabilize translation API in the new frontend system
Remove @alpha tags from translation-related types and switch all
translation API imports in new frontend system packages to use stable
paths from @backstage/frontend-plugin-api instead of
@backstage/core-plugin-api/alpha.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-02-23 21:23:05 +01:00
Patrik Oldsberg 8c3802c5ba Add @backstage/cli to changeset, remove cli-common mock from create-app test
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-23 21:15:48 +01:00
Patrik Oldsberg 641d88cb07 Address PR review comments
- Remove cli-node/src/paths.ts compat layer, migrate all cli-node
  internal usage to import targetPaths from @backstage/cli-common
- Use single-arg overrideTargetPaths('/root') where dir === rootDir
- Scope mockDir to each describe block in bump.test.ts to avoid
  shared state issues with overrideTargetPaths
- Remove unnecessary overrideTargetPaths from plugin-manager.test.ts
- Remove stale findPaths mock from createApp.test.ts
- Use overrideTargetPaths in getWorkspaceRoot.test.ts and cli-node tests

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-23 21:01:27 +01:00
Patrik Oldsberg 3856774252 Merge pull request #32969 from backstage/rugvip/scaffolder-export-form-fields-api
scaffolder: add back form fields API alpha exports
2026-02-23 20:42:57 +01:00