cb80b2b4f8
Refactor: encode state Parameters as URLSearchParams instead of JSON
2020-08-04 18:42:16 +02:00
2d20cf389c
Refactor: Address PR Comments
...
Create a new `OAuthState` type for storing the fields we want in the
`state` parameter.
Update the `encodeState` and `readState` fns to use the new `OAuthState`
type.
Update tests to reflect the new type
2020-08-04 17:06:46 +02:00
51fad03460
Tests: update tests for OAuthProvider to handle
...
Update OAuthProvider tests to ensure that changes to nonce and
environment handling do not cause regressions
2020-08-03 17:43:16 +02:00
3e5dfbc5f6
Refactor: move encoding state parameters into a separate function
2020-08-03 17:42:48 +02:00
081fe60453
Refactor: parse state query param to read nonce
...
The `state` was modified to be an encoded object of `nonce` and `env`.
When verifying the Nonce value in the callback from the authorization
server, parse the state parameter string to read the right value of
nonce
2020-08-03 15:53:22 +02:00
685f76d913
Encode env in OAuth flow into the state parameter. refs #1775
...
`Env` passed as a separate parameter in the request might break the flow
of the authorization flow. Spotify considers the `env` as a first class
abstraction and use it across their application stack.
To ensure both the existing flow and newer flows are supported, use the
`state` parameter to encode an object, consisting of the `nonce` and the
`env` which is then passed to the authorization server. This parameter
is returned to the application in the callbackURL
2020-08-03 15:33:32 +02:00
d15cc81c75
Merge pull request #1760 from spotify/dependabot/npm_and_yarn/http-errors-1.8.0
...
chore(deps-dev): bump http-errors from 1.7.3 to 1.8.0
2020-08-03 10:20:16 +02:00
98342de0a9
Merge pull request #1761 from spotify/dependabot/npm_and_yarn/types/webpack-dev-server-3.11.0
...
chore(deps-dev): bump @types/webpack-dev-server from 3.10.1 to 3.11.0
2020-08-03 10:19:28 +02:00
f510d40170
Merge pull request #1768 from spotify/dependabot/npm_and_yarn/rollup/plugin-node-resolve-8.4.0
...
chore(deps): bump @rollup/plugin-node-resolve from 8.1.0 to 8.4.0
2020-08-03 10:18:53 +02:00
bd3d0de77f
Merge pull request #1745 from ayshiff/refactor/cli-create-app
...
Refactor: Move @backstage/cli create-app to separate package
2020-08-02 22:37:43 +02:00
b5a6d82d5c
feat(create-app): add missing template backend package
2020-08-02 20:30:49 +02:00
5ff1ac0dad
Merge pull request #1803 from spotify/rugvip/gqlfix
...
plugins/graphql: fix schema packaging
2020-08-02 20:29:50 +02:00
650830cf4f
plugins/graphql: fix schema packaging
2020-08-02 19:29:21 +02:00
21d8043878
Merge pull request #1 from spotify/refactor/cli-create-app
...
create-app: packaging fixes
2020-08-02 17:02:49 +02:00
d273c74985
create-app: packaging fixes
2020-08-02 16:28:27 +02:00
5e78cc1082
fix(create-app): update entrypoint
2020-08-02 13:46:28 +02:00
7994c64c54
Merge pull request #1793 from andrewthauer/config-string-fallback
...
Fallback to string if config value is not json
2020-07-31 18:43:34 +02:00
dbcc1383e0
Merge pull request #1799 from spotify/doc-tweaks
...
Tweaks to techdocs docs
2020-07-31 18:16:24 +02:00
0bd997d981
feat: fallback to string value if config value is not json
2020-07-31 06:36:37 -04:00
cd5755cdfd
Merge pull request #1796 from spotify/rugvip/postwut
...
cli: just print warning if postpack fails
2020-07-31 11:40:05 +02:00
9131b9b5b1
yarn.lock: security fix ( #1797 )
2020-07-31 11:35:58 +02:00
730d1b21be
fix(cli): add create-app import to e2e tests
2020-07-31 10:34:00 +02:00
5c79a0d314
cli: just print warning if postpack fails
2020-07-31 10:19:17 +02:00
21c57181f0
Merge pull request #1795 from spotify/pianilsson-patch-1
...
broken link to create an app
2020-07-31 09:42:45 +02:00
d4a50e82c5
Merge pull request #1762 from spotify/shmidt-i/github-actions-widget-redone
...
feat(github-actions): widget inside catalog
2020-07-31 09:33:21 +02:00
377bd94338
broken link to create an app
2020-07-31 09:23:10 +02:00
fe4430907a
Merge pull request #1787 from DavidJSykes/Fix-TechDocs-missing
...
Fix tech docs missing #1750
2020-07-30 19:32:45 +02:00
353ea4d5da
Merge pull request #1791 from spotify/rugvip/graphqlsrc
...
plugins/graphql: fix main field in publish config
2020-07-30 19:21:52 +02:00
e68e174c3b
plugins/graphql: fix main field in publish config
2020-07-30 18:24:35 +02:00
cc905069d1
Changed optional parameter name to allow for more generic uses
2020-07-30 16:57:38 +01:00
f1b96fe8ef
Merge pull request #1783 from AmericanAirlines/ghe
...
Add configuration for github enterprise
2020-07-30 17:19:38 +02:00
64239b9bb3
Merge pull request #1789 from GoWind/remove-scope-check
...
(auth-backend) Bugfix: Do not throw Exception if scopes dont exist. Refs #1786
2020-07-30 17:17:16 +02:00
0fe2ddf70f
Tweaks to techdocs docs
...
Text editing
2020-07-30 17:04:03 +02:00
b625b19978
use cammel case
2020-07-30 09:50:08 -05:00
eea54c55b0
Merge pull request #1782 from twishasaraiya/techdocs/docs-header
...
techdocs: modify documentation header
2020-07-30 16:48:18 +02:00
5cde7069cf
Pass github enterprise base url, derive urls for authentication
2020-07-30 09:33:12 -05:00
343b922e8f
Removed <br /> using seperate Typography element instead
2020-07-30 15:17:38 +01:00
448767712b
(auth-backend) Bugfix: Do not throw Exception if scopes dont exist. Refs #1786
...
Currently, the OAuthProvider library in `auth-backend` throws an
Exception if scopes are missing in the `start` (initial) request
in the Authorization flow. Scopes are an optional parameter as per the
spec, so if scopes are empty, simply forward the empty scopes instead of
throwing an Exception
2020-07-30 15:16:54 +02:00
87ed1a73a8
Merge pull request #1784 from spotify/rugvip/safari
...
core-api: ensure instantPopup is synchronous in RefreshingAuthSessionManager
2020-07-30 15:10:56 +02:00
69d7f9cc92
Merge pull request #1785 from spotify/rugvip/salmon
...
auth-backend: set SameSite=Lax for oauth flow cookies
2020-07-30 15:10:50 +02:00
679f24fc61
Merge pull request #1769 from spotify/Rugvip-patch-2
...
Add coding guidelines to CONTRIBUTING
2020-07-30 15:07:46 +02:00
2930e081a5
core-api: ensure instantPopup is synchronous in RefreshingAuthSessionManager
2020-07-30 12:45:36 +02:00
54610c9ba4
auth-backend: set SameSite=Lax for oauth flow cookies
2020-07-30 12:37:02 +02:00
58fa8ce5fb
Updated test
2020-07-30 11:35:01 +01:00
4f54f062fe
Updated test
2020-07-30 11:31:26 +01:00
ea57820c62
Removed a div that was no longer needed
2020-07-30 11:30:01 +01:00
fa708d6572
TechDocsNotFound now uses ErrorPage from core with an optional docPath parameter
2020-07-30 11:19:12 +01:00
5ae8479e39
Added optional docPath parameter to ErrorPage and used it to display docPath for missing TechDocs
2020-07-30 11:18:20 +01:00
c3fc889d12
Exported ErrorPage and reordered exports
2020-07-30 11:17:24 +01:00
c0feeecc29
Add documentation
2020-07-30 04:53:35 -05:00
Govindarajan Nagarajan