d7def5d0cb
PR Feedback
...
* Tidy up passing of domain hint from initalisation to later methods
* Tidy up change set
Signed-off-by: Alex Crome <afscrome@users.noreply.github.com >
2023-10-25 21:49:23 +01:00
3979524c74
Add domain_hint support to Entra ID login
...
When a user is logged in to multiple microsoft accounts, there can be be a little bit of friction in the Entra login process as users will be asked to select the account to login with.
Scenarios in which a user may have multiple microsoft accounts
1. Someone logged in to your work Entra ID account, and a personal microsoft account
2. A consultant who has an Entra ID account at both their employer, as well as the company they're contracted out to.
3. A user has a regular account, as well as one or more high priviliged accounts.
When a domain hint is provided, Entra will filter out all the accounts which don't belong to the tenant specified on the `domain_hint`.
In many cases, this will filter to a single account, avoiding the need to select an account at all (e.g. scenario 1 & 2).
This won't always happen (e.g. scenario 3).
Additionally in the case a tenant has been configured to federate authentication elsewhere (e.g. to an on premise AD FS), setting the domain hint means entra can send the user straight to the federated authentication soruce, removing further steps
If backstage is allowign authentication from multiple tenants, this field should be left blank.
For more details, see https://learn.microsoft.com/en-us/azure/active-directory/manage-apps/home-realm-discovery-policy
99% of the time, this value should be the same as the tenantId, so we could get rid of hte domain hint, and set it to the same value as the tenant id automatically.
We'd need to provide a config option (e.g. `isMultiTenant: true`) to opt out of this.
For those edge cases, this would be a breaking change.
I decided to go with specifying the `domain_hint` seperatly for now just in case my assumptions are wrong and there are more cases wher ehte `domain_hint` will get in the way.
We can always make this the default behaviour later on.
Signed-off-by: Alex Crome <afscrome@users.noreply.github.com >
2023-10-19 23:01:14 +01:00
bae9015f2b
Merge pull request #20683 from backstage/mob/routed-tabs-fix
...
core-components: make RoutedTabs not explode when rendering without tabs
2023-10-19 20:51:59 +02:00
bdb4fbf83f
Merge pull request #20689 from kuangp/fix/config-loader
...
fix(configLoader): properly resolve targets into absolute paths
2023-10-19 20:45:34 +02:00
8fed4d5e75
Merge pull request #20688 from backstage/rugvip/wait
...
search: more reliable wait in test
2023-10-19 20:35:34 +02:00
22ca64f117
fix(configLoader): properly resolve targets into absolute paths
...
Signed-off-by: Phil Kuang <pkuang@factset.com >
2023-10-19 13:57:38 -04:00
1f0b6b1e48
search: more reliable wait in test
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2023-10-19 19:06:01 +02:00
acc1b37a23
Merge pull request #20687 from backstage/rugvip/schema
...
frontend-app-api: fix configuration schema
2023-10-19 18:59:19 +02:00
776d2c3fca
Merge pull request #20650 from anicke/cookiecutter-mockfs
...
Scaffolder/cookiecutter: Remove usage of mock-fs
2023-10-19 17:38:27 +02:00
dc613f9bcf
frontend-app-api: fix configuration schema
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2023-10-19 17:33:37 +02:00
81c8db2088
core-components: make RoutedTabs not explode when rendering without tabs
...
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2023-10-19 16:34:02 +02:00
d04b6706cc
Merge pull request #20586 from backstage/camilaibs/improve-error-boundary-component
...
[DI] Improve `ExtensionBoundary` component
2023-10-19 16:22:06 +02:00
9dc88681c8
Merge pull request #20590 from parmar-abhinav/master2
...
Add examples for github:webhook scaffolder actions
2023-10-19 15:07:29 +02:00
052998a180
Use setContent instead of clear plus addContent
...
Signed-off-by: Niklas Aronsson <niklasar@axis.com >
2023-10-19 14:55:16 +02:00
66af240ea6
refactor(frontend-plugin-api): merge boundary and suspense components
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 14:54:35 +02:00
ce4ffacd6e
Merge pull request #20676 from backstage/rugvip/fix
...
docs: fix links to analytics-module-ga README
2023-10-19 14:28:52 +02:00
a6efee3040
Merge pull request #20456 from backstage/camilal/migrate-stackoverflow-to-declarative-integration
...
[DI] Migrate `Stack Overflow` plugins to declarative integration
2023-10-19 14:15:34 +02:00
6d469fa872
Merge pull request #20668 from Ankit-netizens/scaffolder-rails-no-mock-fs
...
Replaced mock-fs in scaffolder rails
2023-10-19 14:04:31 +02:00
cca1afc547
refactor(search): restore inline attachment
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 13:57:54 +02:00
1b8f005aab
refactor(catalog): restore inline attachment
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 13:57:35 +02:00
816493a7c5
docs: fix links to analytics-module-ga README
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2023-10-19 13:55:47 +02:00
124ba80362
Merge pull request #20675 from drodil/techdocs_fail_message_improvement
...
chore: add info about entity if tech docs building fails
2023-10-19 13:54:02 +02:00
28d1f6004d
Merge pull request #20669 from awanlin/docs/new-backend-updates
...
docs: new backend system updates
2023-10-19 13:52:15 +02:00
c3c5c7e514
chore: add info about entity if tech docs building fails
...
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi >
2023-10-19 14:28:44 +03:00
0fb1d8c7f8
removed mockdir.clear, replaced addContent with setContent
...
Signed-off-by: Ankit Anand <ankitanand.l@flipkart.com >
2023-10-19 16:52:06 +05:30
e766ea5b88
Merge pull request #20672 from backstage/mob/app-compat
...
app-compat-api: add helper for converting entire app
2023-10-19 12:57:58 +02:00
e964c17db9
chore(catalog): add changeset file
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
11555a0da0
refactor(catalog): forward plugin to extension boundary
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
e7c09c4f4b
chore(search-react): add changeset file
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
b51919e3eb
refactor(search-react): use extension boundary and suspense
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
6af88a05ff
chore(frontend-plugin-api): add changeset file
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
c1e10b6175
docs(frontend-plugin-api): update api reports
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
42a8ef3a4f
test(frontend-plugin-api): cover create page extension
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
103b405746
feat(frontend-plugin-api): use extension boundary and suspense
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
055b7aec3d
test(frontend-plugin-api): cover extension suspense component
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
2610774e4b
feat(frontend-plugin-api): create extension suspense
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
b2dcb92c36
test(frontend-plugin-api): cover extension boundary component
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
ed71a018b1
feat(frontend-plugin-api): improve extension boundary
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:33:28 +02:00
e13e43a125
refactor(stack-overflow-backend): remove alpha subpath
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:05:19 +02:00
8a7f1ba2a5
docs(stack-overflow): add note about missing hompage card extension
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:05:19 +02:00
d7a4e2225f
fix: changeset package version
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:05:19 +02:00
3b5bef78b2
chore(stack-overflow-backend): deprecate entire package
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:05:19 +02:00
95dc40505a
docs(stack-overflow): update api reports
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:05:19 +02:00
3c39045e2b
refactor: rename stack overflow backend module
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 12:05:19 +02:00
ec21927c0d
Merge pull request #20673 from backstage/rugvip/import
...
dev-utils,techdocs: use dynamic import instead of require for conditional react-dom
2023-10-19 11:27:51 +02:00
67cc85bb14
dev-utils,techdocs: use dynamic import instead of require for conditional react-dom
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2023-10-19 10:53:42 +02:00
720656a4a9
Merge pull request #20605 from backstage/camilaibs/export-techdocs-routes
...
[DI] Export `TechDocs` routes and nav item extension
2023-10-19 10:19:55 +02:00
0eaa698bb5
chore(frontend-plugin-api): install frontend app api
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2023-10-19 10:10:02 +02:00
38510c0a2b
Merge pull request #20621 from backstage/dependabot/npm_and_yarn/undici-5.26.3
...
build(deps): bump undici from 5.25.4 to 5.26.3
2023-10-19 09:51:19 +02:00
821a7864f9
Merge pull request #20654 from RoadieHQ/add-logger-metadata
...
add `factRetrieverId` to the logger metadata
2023-10-19 09:49:13 +02:00
Alex Crome