f12cb33bd5
passing down isGroup value from ownershipCard to useGetEntities
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:56:56 +07:00
102e6efea5
fix test ownership card
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:35:20 +07:00
103b72b704
update to just use one hooks and one component grid in ownership card
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:20:30 +07:00
69d652f3cc
use relations.ownedBy for filter params in getEntities
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:26 +07:00
e4d5b8c7ff
rename owner to ownerEntity for getQueryParams
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
80b47162be
fix failing test for links to the catalog with group filter
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
4a790094ee
use humanizeEntityRef
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
da70c0ef1a
check looping from length of requestedEntities
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
be6b97e2ed
change to use getEntityByRef
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
303bc1c7fb
use prettier
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
d9497b9b6e
change filterKinds in OwnershipCard test
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
b759a21c96
change isOwnerOf to use filter relations.ownedBy
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
5606d6065b
use getEntityRelations to get all memberOf groups
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:25 +07:00
8183a00eae
change system test expectation for displays entity counts case
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
3e1a4ed473
use additional kind system for OwnershipCard test
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
fce26e8204
change to use supported version of useAsync
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
21f99270bb
change transitive word to aggregated
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
8e9ddcc5f0
change label props
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
b0dcb1289f
fix typo comment in changeset
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
539a0d754c
remove catalogListResponse from import statement
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
111995470d
add changeset
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
19fe9bfafb
add checked props to switch component
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:24 +07:00
2566b48ebb
transitive ownership of entities for group kind
...
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com >
2022-03-24 14:12:17 +07:00
4431873583
Add changeset
...
Signed-off-by: Joe Porpeglia <josephp@spotify.com >
2022-03-23 16:07:10 -04:00
c84d4ad373
Fix usePermission usage
...
Signed-off-by: Joe Porpeglia <josephp@spotify.com >
2022-03-23 16:07:10 -04:00
3e0bbeda8b
permission-react: fix usePermission tests
...
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com >
2022-03-23 16:07:10 -04:00
8c6129d3e0
permission-react: inline parameter type to clean up the api report a bit
...
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com >
2022-03-23 16:07:10 -04:00
91703e8086
permission-react: use object instead of tuple for usePermission args
...
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com >
Signed-off-by: Joe Porpeglia <josephp@spotify.com >
2022-03-23 16:07:10 -04:00
d88b5b3009
permission-react: fix changeset typo
...
Co-authored-by: Joe Porpeglia <josephp@spotify.com >
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com >
2022-03-23 16:07:10 -04:00
5bdcb8c45d
permission-react: more restrictive typing for usePermission and PermissionedRoute
...
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com >
2022-03-23 16:07:10 -04:00
9da18e4715
search: throw error for unexpected non-resource permissions when authorizing result-by-result
...
We only reach this point in the code for types where the initial
authorization returned CONDITIONAL -- ALLOWs return early immediately
above, and types where the decision was DENY get filtered out entirely
when querying.
This means the call to isResourcePermission here is mostly about
narrowing the types, since the only way for it to be false is if the
PermissionPolicy returned a CONDITIONAL decision for a non-resource
permission, which can't happen - it would throw an error during
validation in the permission-backend.
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com >
2022-03-23 15:58:42 -04:00
30f9884359
search: check for non-resource permissions when authorizing results
...
Now that we can differentiate between ResourcePermissions and other
kinds of permissions, we can skip authorizing result-by-result
when the permission for a given document type is not a
ResourcePermission.
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com >
2022-03-23 15:58:42 -04:00
1e0dbd4fb5
Add todo
...
Signed-off-by: Joe Porpeglia <josephp@spotify.com >
2022-03-23 14:25:14 -04:00
146ea2117b
catalog-common: mention that CatalogEntityPermission type is alpha in changeset
...
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com >
2022-03-23 14:25:14 -04:00
8cb7acd781
catalog-react: stop using CatalogEntityPermission convenience type
...
There's currently an issue with importing alpha exports from other
packages in the monorepo. This works around the issue for now by
skipping the use of the `CatalogEntityPermission` convenience type,
using `ResourcePermission<'catalog-entity'>` directly instead.
cf. https://github.com/backstage/backstage/pull/10128
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com >
2022-03-23 14:25:14 -04:00
0ffd88a90e
catalog-react: require CatalogEntityPermission in useEntityPermission
...
Now that we have stricter typing for permissions, we can restrict the
useEntityPermission hook to only be used with permissions of type
`CatalogEntityPermission`.
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com >
2022-03-23 14:25:14 -04:00
8c8bee47f4
catalog-common: add CatalogEntityPermission convenience type
...
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com >
2022-03-23 14:25:14 -04:00
6a8c4251a1
Merge pull request #10291 from RoadieHQ/allow-customizing-default-catalog-component
...
Expose initialFiliter from Catalog Page
2022-03-23 17:03:36 +01:00
0c7c7ea870
Merge pull request #10398 from backstage/rugvip/tweaks
...
workflows: switch changeset feedback back to service account
2022-03-23 15:32:09 +01:00
4366dfffb8
Merge pull request #10386 from backstage/dependabot/npm_and_yarn/apollo-server-express-3.6.5
...
build(deps): bump apollo-server-express from 3.6.4 to 3.6.5
2022-03-23 15:28:24 +01:00
a0941d5fc3
workflows: switch changeset feedback back to service account
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-23 15:23:45 +01:00
7fae0c07e9
Merge pull request #10381 from backstage/dependabot/npm_and_yarn/eslint-plugin-jest-26.1.2
...
build(deps): bump eslint-plugin-jest from 25.3.4 to 26.1.2
2022-03-23 13:57:49 +01:00
7a672ea848
Merge pull request #10388 from backstage/blam/whoops-changeset
...
Adjust changeset version bump
2022-03-23 13:42:16 +01:00
0b3e95b0c7
Merge pull request #10384 from backstage/dependabot/npm_and_yarn/spotify/eslint-config-base-13.0.0
...
build(deps): bump @spotify/eslint-config-base from 12.0.0 to 13.0.0
2022-03-23 13:31:50 +01:00
ba8978e7cc
Merge pull request #10392 from backstage/rugvip/tweaks
...
workflows: more tweaks to the changeset feedback automation
2022-03-23 13:10:08 +01:00
d392e27f5c
workflows: changeset feedback no longer breaks when changesets are removed
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-23 12:44:00 +01:00
7cdc9ecc07
workflows: make changeset feedback diff only PR contents
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-23 12:43:34 +01:00
70181cddd5
workflows: skip changeset feedback back to bot account
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-23 12:43:03 +01:00
bac26e969a
Merge pull request #10389 from backstage/freben/minimist
...
bump past vulnerable minimist
2022-03-23 11:16:13 +01:00
40c542d390
Merge pull request #10391 from backstage/rugvip/tweaks
...
workflows: changeset feedback automation tweaks
2022-03-23 11:07:20 +01:00
Prasetya Aria Wibawa