Commit Graph

21571 Commits

Author SHA1 Message Date
Iain Billett f45e99e5da Changeset
Signed-off-by: Iain Billett <iain@roadie.io>
2022-01-18 18:09:14 +00:00
Iain Billett 2030b5e80d Return an empty token where an installation owner is not allowed
While this is less obvious to the user this facilitates anonymous access
to (public) files where the app is installed but the owner is not in the
allowed list.

Signed-off-by: Iain Billett <iain@roadie.io>
2022-01-18 18:02:47 +00:00
Fredrik Adelöw 5387ea8f0d Merge pull request #9007 from backstage/blam/goalie-workflows
chore: split the goalie workflows for permissions
2022-01-18 18:54:46 +01:00
Patrik Oldsberg a724d38208 Merge pull request #9000 from backstage/rugvip/noignore
remove usage of @ts-ignore
2022-01-18 18:46:28 +01:00
Joe Porpeglia ffa0ecfac4 Remove unused dependency
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia 597f7a604d Update changeset
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia ca2ee182c3 Add changeset
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia f911a60baf Update api-report
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia cd3c5b132e Update package exports to align with ADR004
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia ccaa50511f Make getCacheKey sync
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia 63e8b8605e Disable catalog permission middleware unless permission.enabled = true
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia 17ebcb09cd Refactor router tests
Adds a `createApp` helper instead of creating the express app in `beforeEach`. This allows tests to mock behavior of router creation, like toggling certain middleware based on config values.

Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia f1918143e5 Compute cache keys from tokens instead of user entity refs
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia e9857d0b82 Remove 403 handling logic
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia d9afa2e882 Add tests to verify /static/docs behavior
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia c2f54048d1 Use catalog: prefix for catalog entity cache
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia 413c9fab08 Cancel cache read if it takes too long
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia f5598677bf Set cache value asynchronously
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia 45f37c9835 Use CachedEntityLoader in techdocs router
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia 7dcc6b1fe6 Add CachedEntityLoader for techdocs
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-01-18 12:43:35 -05:00
Joe Porpeglia b76fec242d Verify access to related catalog entities for all techdocs api routes
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
Co-authored-by: Nataliya Issayeva <nissayeva@users.noreply.github.com>
2022-01-18 12:43:35 -05:00
blam ec33c21c9d chore: make the workflows pretty
Signed-off-by: blam <ben@blam.sh>
2022-01-18 18:33:21 +01:00
blam 0163fb056f chore: run the goalie Workflow
Signed-off-by: blam <ben@blam.sh>
2022-01-18 18:31:19 +01:00
blam c6946dedbe chore: missed the Codeowners
Signed-off-by: blam <ben@blam.sh>
2022-01-18 18:24:29 +01:00
blam e23c2463d5 chore: move out script into one file instead because args were too long
Signed-off-by: blam <ben@blam.sh>
2022-01-18 18:22:44 +01:00
blam 5cefc14d51 chore: more comment removal?
Signed-off-by: blam <ben@blam.sh>
2022-01-18 18:11:08 +01:00
blam 1129e3d1bc chore: remove some comments and maybe it works?
Signed-off-by: blam <ben@blam.sh>
2022-01-18 18:07:28 +01:00
blam 557ad7e462 feat: split out the workflow to run for each open PR
signed-off-by: blam <ben@blam.sh>
2022-01-18 18:04:46 +01:00
blam 65b0d1b3fd chore: dont destructure
Signed-off-by: blam <ben@blam.sh>
2022-01-18 17:45:03 +01:00
blam f2bb24298f chore: added some debug logging
Signed-off-by: blam <ben@blam.sh>
2022-01-18 17:43:40 +01:00
blam c732188aee chore: goalie cron
Signed-off-by: blam <ben@blam.sh>
2022-01-18 17:42:14 +01:00
blam f38b57fcf7 chore: run every minute
Signed-off-by: blam <ben@blam.sh>
2022-01-18 17:38:06 +01:00
blam 196e572e98 chore: rename the workflow so it runs
Signed-off-by: blam <ben@blam.sh>
2022-01-18 17:35:50 +01:00
blam 9af839d296 chore: split the workflows
Signed-off-by: blam <ben@blam.sh>
2022-01-18 17:33:48 +01:00
Joon Park 6680853e0c Export conditional permission policy helpers from catalog-backend (#8966)
* Export conditional permission policy helpers from catalog-backend

Signed-off-by: Joon Park <joonp@spotify.com>

* Rename exports to include 'catalog'

Signed-off-by: Joon Park <joonp@spotify.com>

* Minor comment edits

Co-authored-by: MT Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Joon Park <joonp@spotify.com>

Co-authored-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-18 16:04:57 +00:00
Fredrik Adelöw dc68ebc6de Merge pull request #9005 from msfuko/master
Add Hopin to the list of adopters
2022-01-18 16:59:54 +01:00
Joon Park 7e38acaa9e Integrate permissions into catalog-backend location endpoints (#8887)
Signed-off-by: Joon Park <joonp@spotify.com>
2022-01-18 15:55:49 +00:00
Chloe Lee 48b86d2929 Add Hopin to the list of adopters 2022-01-18 10:39:57 -05:00
Ben Lambert 79a7d37964 Merge pull request #9003 from backstage/blam/goalie-workflows
Goalie workflow running on forks
2022-01-18 16:11:45 +01:00
Patrik Oldsberg 31184691d5 Merge pull request #8921 from backstage/changeset-release/master
Version Packages (next)
2022-01-18 15:59:26 +01:00
blam b0755576c2 chore: pretty
Signed-off-by: blam <ben@blam.sh>
2022-01-18 15:16:42 +01:00
blam 08923f548f chore: change permissions
Signed-off-by: blam <ben@blam.sh>
2022-01-18 15:12:36 +01:00
blam 9bfe00c351 chore: spoiler alert, it's a secret
Signed-off-by: blam <ben@blam.sh>
2022-01-18 15:11:24 +01:00
blam 5ca2edfcb9 chore: try this token?
Signed-off-by: blam <ben@blam.sh>
2022-01-18 15:09:05 +01:00
blam f44a185ab7 chore: maybe these tokens workflows
Signed-off-by: blam <ben@blam.sh>
2022-01-18 15:05:31 +01:00
blam 192a8bc84a set the org as it's installed at an org level
Signed-off-by: blam <ben@blam.sh>
2022-01-18 15:03:48 +01:00
Patrik Oldsberg 0925b232fc create-app: fix release version to 0.4.13
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-01-18 14:57:45 +01:00
github-actions[bot] a94a2b8b3f Version Packages (next) 2022-01-18 13:49:07 +00:00
Patrik Oldsberg e9861467d0 Merge pull request #8999 from backstage/rugvip/clipre
cli: fix versioning provider test to work with pre-releases
2022-01-18 14:42:46 +01:00
blam 5a49582e93 chore: fix syntax
Signed-off-by: blam <ben@blam.sh>
2022-01-18 14:35:27 +01:00