refactor(scaffolder-backend): apply review suggestions

Signed-off-by: Camila Belo <camilaibs@gmail.com>

plugins/scaffolder-backend/src/scaffolder/dryrun/createDryRunner.ts

@@ -41,7 +41,7 @@ interface DryRunInput {
   spec: TaskSpec;
   secrets?: TaskSecrets;
   directoryContents: SerializedFile[];
-  getInitiatorCredentials(): Promise<BackstageCredentials>;
+  credentials: BackstageCredentials;
 }
 
 interface DryRunResult {
@@ -118,7 +118,7 @@ export function createDryRunner(options: TemplateTesterCreateOptions) {
           },
         },
         secrets: input.secrets,
-        getInitiatorCredentials: input.getInitiatorCredentials,
+        getInitiatorCredentials: () => Promise.resolve(input.credentials),
         // No need to update this at the end of the run, so just hard-code it
         done: false,
         isDryRun: true,

plugins/scaffolder-backend/src/service/router.ts

@@ -626,9 +626,7 @@ export async function createRouter(
           ...(token && { backstageToken: token }),
           initiatorCredentials: JSON.stringify(credentials),
         },
-        getInitiatorCredentials(): Promise<BackstageCredentials> {
-          return Promise.resolve(credentials);
-        },
+        credentials,
       });
 
       res.status(200).json({